SAFEDIV is not included into XMILE specification

SDXorg / test-models

A collection of System Dynamics models implemented in various environments with a canonical output

MIT License

27 stars 22 forks source link

SAFEDIV is not included into XMILE specification #39

Open alexprey opened 7 years ago

alexprey commented 7 years ago

Model file: https://github.com/SDXorg/test-models/blob/master/tests/xidz_zidz/xidz_zidz.xmile

This model file has wrong definition for XMILE specification http://docs.oasis-open.org/xmile/xmile/v1.0/csprd01/xmile-v1.0-csprd01.html

SAFEDIV function is not exists by specification.

Regards, Alexey from sdCloud.io development team.

JamesPHoughton commented 7 years ago

@wasbridge - is this one of the xmutil translated tests?

wasbridge commented 7 years ago

Yes -- this is a translated test from XMUtil -- XMUtil takes XIDZ and ZIDZ and turns them into a Stella specific function (missing from XMILE) called SAFEDIV(num, denom, val). For a v2 of the spec we should probably add SAFEDIV or something like it since there is currently no clean way to do it in "native" XMILE