search

SDXorg / test-models

A collection of System Dynamics models implemented in various environments with a canonical output
MIT License
27 stars 22 forks source link

NOT operation for XMILE logicals test has wrong definition #40

Closed alexprey closed 7 years ago

alexprey commented 7 years ago

The model file: https://github.com/SDXorg/test-models/blob/master/tests/logicals/test_logicals.xmile

This model file has wrong definition at line 33

<eqn>( IF false_input not  THEN 1 ELSE 0 )</eqn>

Should be

<eqn>( IF not false_input THEN 1 ELSE 0 )</eqn>

Regards, Alexey from sdCloud.io development team.

JamesPHoughton commented 7 years ago

Looks like this had been correct in an earlier commit and was overwritten with the xmutil test generations.

@wasbridge - looks like :not: parsing in xmutil is broken.

I'm going to approve the PR, to bring the test to where it should be.

JamesPHoughton commented 7 years ago

Thanks @alexprey for a good catch. =)

wasbridge commented 7 years ago

Yup -- let me bring this bug back upstream in XMUtil