mojosoeun commented 6 years ago

pagination test 추가하였습니다. -- 같은 pagination을 클릭할 경우 이동하지 않는다도 테스트 해야하는지 고민이 생겼어용..
karma에 istanbul을 추가하여 콘솔에 test-coverage가 노출되도록 수정하였습니다.

hyeonmi commented 6 years ago

같은 pagination을 클릭할 경우 이동 하지 않는 테스트 추가하는게 좋을것 같아요!

hyeonmi commented 6 years ago

branch 커버리지 낮네요 ㅠ

mojosoeun commented 6 years ago

@hyeonmi 확인 부탁드립니당~

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@315d61a). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #53   +/-   ##
==========================================
  Coverage           ?   90.74%           
==========================================
  Files              ?       11           
  Lines              ?      216           
  Branches           ?        0           
==========================================
  Hits               ?      196           
  Misses             ?       20           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 315d61a...c538c46. Read the comment docs.

mojosoeun commented 6 years ago

@hyeonmi 현미님 다시 한번 확인 부탁드려용!

SE-Jr / tada.js

feat(-): pagination test 및 karma에 test coverage 설정 #53

Codecov Report