search

SE310-1 / W.A.K

W.A.K is a movie tracker web-app developed to simplify and enhance the movie-rating experience while making this process more fun and customisable.
MIT License
2 stars 12 forks source link

Facebook sign-in window doesn't allow users to sign in #94

Open vdav02 opened 11 months ago

vdav02 commented 11 months ago

Describe the bug When a user tries to log in with Facebook, the popup window which should redirect them to an external Facebook sign-in page doesn't work, and simply says that 'something went wrong'.

Test cases N/A - identified when reviewing PR #93

To Reproduce Try and sign in using your Facebook login

Expected behavior A popup appears which directs you to an external Facebook sign-in page, where you can then enter your Facebook credentials to sign in to your Facebook account.

Stack Traces The following is a screenshot from the Console of the website in the browser, when Inspect Element is selected

image

Error Reports N/A

Screenshots This is the popup window which should allow the users to sign in with their Facebook credentials, but is instead in an error state.

image

The Facebook button in the screenshot below is the one which was clicked to cause the popup sign-in window to appear.

image

Device the bug was found on (please complete the following information):

Additional context The Facebook server is throwing a 500 Internal Server Error.

leas022 commented 11 months ago

I can confirm I have encountered this issue as well. After research it appears that Facebook have updated the version of their API to v18.0 and deprecated all other versions. Currently all react libraries use previous versions of the API that are only available if you created the Facebook developer app when that version was non-deprecated. Unfortunately this looks like it might be a bit of work to implement Facebook login - possibly could hold off implementing this feature until react components are updated to support v18.0 of Facebook's API?

vdav02 commented 11 months ago

I also trawled through a fair few Facebook blog posts, Github discussions and StackOverflow response to try and find the root cause of this issue, and it seems like the API update made by Facebook is the cause of this to me as well. I've only seen a couple of solutions, and they required the creation of React components from scratch and coordinating with Facebook developers to sync with them - this definitely doesn't seem like a plausible option given the scope of our upcoming release. It's a little unfortunate that Facebook won't extend their backwards compatibility to projects made after their API upgrade. Overall, I agree that the best course of action at this stage is to push the Facebook sign in implementation to a later release and close this issue, as there's little we can feasibly do from our end at this stage to make the sign-in work.