SE701-T5 / Backend

Heroku deployed Node.js backend server developed by Team-5 for the UniForum project associated with the University of Auckland SOFTENG 701 course

https://uni-forum.herokuapp.com/

MIT License

2 stars 18 forks source link

Fix existing endpoints #102

Closed justcrossheaven closed 2 years ago

justcrossheaven commented 2 years ago

Description

Fix existing endpoints

Fixes/resolves #100, resolves #98

Screenshots

Please include any screenshots or media that illustrates the changes made

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (non-breaking change which improves existing functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

Leave blank if not applicable

I have completed these steps when making this pull request:

[x] I have checked that the PR is from a forked repository
[x] I have assigned my name to the issue
[x] I have moved the issue to the In Progress column
[x] I have labelled the PR appropriately
[x] I have assigned people responsible to the PR

Before opening the PR for review:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have documented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] I have moved the linked issue to the Review in Progress column

j-chad commented 2 years ago

middleware.lib.ts Line 24 in isAuthenticated() - is it possible to refactor the nested try catch

This currently has to be there due to a limitation in how express cannot catch errors in asynchronous code