SE701-T5 / Frontend

This is the frontend repo of Uni-forum, associated with the University of Auckland, SOFTENG701. This repo will be linked to Netlify for ease of deployment and code review
MIT License
1 stars 22 forks source link

New post page layout #30

Closed yuchendong13 closed 2 years ago

yuchendong13 commented 2 years ago

Description

NOTE: After consulting with Frontend lead @christopher-alba, the justification of the 'Title' and 'Forum selection' fields have been slightly modified from the initial Figma design. The fields now span the whole container instead of being a bit shorter.

Related Issue

Solves Issue #27

Type of change

How Has This Been Tested?

Checklist:

netlify[bot] commented 2 years ago

โœ”๏ธ Deploy Preview for uniforum ready!

๐Ÿ”จ Explore the source changes: 989f47e9762c06a2b845172f240a811a91bc5867

๐Ÿ” Inspect the deploy log: https://app.netlify.com/sites/uniforum/deploys/6231a1821a9f2b00089d6e17

๐Ÿ˜Ž Browse the preview: https://deploy-preview-30--uniforum.netlify.app/

yuchendong13 commented 2 years ago

Thanks for the feedback Chris. Yup that's definitely a good point, sorry it slipped my mind since it wasn't on the design but it should be a given.

hpar461 commented 2 years ago

Hi! A couple of UI issues coming through:

  1. as you can see in the image below, when you select the forum dropdown, the title gets pushed to the border but then it overlaps with the border. Prob need some fix.

    Screenshot 2022-03-16 แ„‹แ…ฉแ„’แ…ฎ 9 07 37
  2. This is just as it is in the figma UI prototype, but considering the overall design of the website, it might be better in terms of overall aesthetics if the corners for the new post component could be rounded a bit; perhaps around 8~10px?

Thanks!

yuchendong13 commented 2 years ago

Thanks for the review Hyung. I will have a look into the title in border problem as the gap in the border seems to be part of the default material UI design. As for your second point, I definitely agree that rounded corners will look better.