Closed yuchendong13 closed 2 years ago
โ๏ธ Deploy Preview for uniforum ready!
๐จ Explore the source changes: 989f47e9762c06a2b845172f240a811a91bc5867
๐ Inspect the deploy log: https://app.netlify.com/sites/uniforum/deploys/6231a1821a9f2b00089d6e17
๐ Browse the preview: https://deploy-preview-30--uniforum.netlify.app/
Thanks for the feedback Chris. Yup that's definitely a good point, sorry it slipped my mind since it wasn't on the design but it should be a given.
Hi! A couple of UI issues coming through:
as you can see in the image below, when you select the forum dropdown, the title gets pushed to the border but then it overlaps with the border. Prob need some fix.
This is just as it is in the figma UI prototype, but considering the overall design of the website, it might be better in terms of overall aesthetics if the corners for the new post component could be rounded a bit; perhaps around 8~10px?
Thanks!
Thanks for the review Hyung. I will have a look into the title in border problem as the gap in the border seems to be part of the default material UI design. As for your second point, I definitely agree that rounded corners will look better.
Description
NOTE: After consulting with Frontend lead @christopher-alba, the justification of the 'Title' and 'Forum selection' fields have been slightly modified from the initial Figma design. The fields now span the whole container instead of being a bit shorter.
Related Issue
Solves Issue #27
Type of change
How Has This Been Tested?
Checklist: