SE701-T5 / Frontend

This is the frontend repo of Uni-forum, associated with the University of Auckland, SOFTENG701. This repo will be linked to Netlify for ease of deployment and code review
MIT License
1 stars 22 forks source link

Added CommunityPreviewComponent and Communities page #48

Closed yuchendong13 closed 2 years ago

yuchendong13 commented 2 years ago

Description

Related Issue

Solves Issue #33

Type of change

How Has This Been Tested?

Checklist:

netlify[bot] commented 2 years ago

āœ… Deploy Preview for uniforum ready!

šŸ”Ø Explore the source changes: 2031226933f9e2a5fd5abb9f3a2d24753ec4839e

šŸ” Inspect the deploy log: https://app.netlify.com/sites/uniforum/deploys/6235a0fc5fb5e90008a54e20

šŸ˜Ž Browse the preview: https://deploy-preview-48--uniforum.netlify.app/

christopher-alba commented 2 years ago

Looks great, but just wondering if we should make the posts and communities pages a bit more consistent because right now the search bar that you have and the search bar that I did for the posts page are different. Also, I do not have the "based on search query..." text under the search bar. Should I also add it in the posts page? Posts page search bar: image

Dont worry about the based on search query text its in one of my PRs :)

yuchendong13 commented 2 years ago

Looks great, but just wondering if we should make the posts and communities pages a bit more consistent because right now the search bar that you have and the search bar that I did for the posts page are different. Also, I do not have the "based on search query..." text under the search bar. Should I also add it in the posts page? Posts page search bar: image

Thanks for the feedback Trinh, I'll change the styling for the search bar to match your one in the posts page! I currently have it matching with the Navbar, but I do think it'll make more sense to match yours.

yuchendong13 commented 2 years ago

Hi reviewers, could you please double-check the app.js - another PR overwrote my route to the communities page so I have created a separate route for 'CommunitiesPage' (not quite sure what the purpose of this is) and routed the old '/Communities' back to my communities page.