Closed christopher-alba closed 2 years ago
✅ Deploy Preview for uniforum ready!
🔨 Explore the source changes: fdb853028addb79a0c43eddb545fccdaa8bf5a2b
🔍 Inspect the deploy log: https://app.netlify.com/sites/uniforum/deploys/6236c92d9678b80008a8b743
😎 Browse the preview: https://deploy-preview-54--uniforum.netlify.app/
Hi, love the changes!
Perhaps one potential UI fix would be on the post preview components, where I've noticed that a link icon? has been appearing on the right side of the title. Perhaps this should be removed following the ui prototype design? Final decision is up to you.
Hi, love the changes!
Perhaps one potential UI fix would be on the post preview components, where I've noticed that a link icon? has been appearing on the right side of the title. Perhaps this should be removed following the ui prototype design? Final decision is up to you.
Yup that's because the title is now also a link to the particular post (based on its ID) so i felt like it needed a call to action for people to realise they can click on it
Looks all good now, but just one potential ui issue at the bottom of the communities page, i think we can add . padding-bottom:20px for the class com-bodyContainer in the communities.css.
Hi, love the changes! Perhaps one potential UI fix would be on the post preview components, where I've noticed that a link icon? has been appearing on the right side of the title. Perhaps this should be removed following the ui prototype design? Final decision is up to you.
Yup that's because the title is now also a link to the particular post (based on its ID) so i felt like it needed a call to action for people to realise they can click on it
Right! That's algood then. Thanks!
Looking good, thanks for all the hard work! Just following on from Xiaoqi's comment, since we added padding to the communities page, did we also want to pad the bottom of the home and posts page?
Lets make this an issue for the next team :P
Description
Related Issue
resolves #53
Type of change
How Has This Been Tested?
Checklist:
For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.