search

SE7ENSKY / jade2php

Unlock Jade for PHP! Convert Jade templates into raw PHP templates. CLI tool and JavaScript API. Test covered.
43 stars 10 forks source link

'jade_indent = []' on the top of php file #18

Closed OnkelTem closed 9 years ago

OnkelTem commented 9 years ago

On the top of resulting file I get one extra line:

var jade_indent = [];
<!DOCTYPE html>

I invoke jade2php from gulp using gulp-jade2php

ivankravchenko commented 9 years ago

Fixed in jade2php@1.1.8, 2a0993eeb2569e9ba7942b6a6e6e63d03bc79822

OnkelTem commented 9 years ago

Nice "fix", so it is now impossible to let jade to set indents (to at least analyze resulting PHP tempaltes).

How do you estimate the difficulty of providing full support of the pretty print?

Or we can't do anything with surprises like?:

if (this.pp) {
  this.buf.push("var jade_indent = [];");
}
ivankravchenko commented 9 years ago

Pretty code and pretty output options are not implemented. Actually, that was not a fix, just a stub. This is about 3-7 workhours. But I can't asset priority for jade2php next few months.

OnkelTem commented 9 years ago

Pretty code and pretty output options are not implemented.

I'm not arguing, but as I said with this stub we get the output on one line, which is inconvenient when you start developing templates with jade2php.

ivankravchenko commented 9 years ago

Issue was resolved, so closing. Pretty output/code options to be done.