search

SE7ENSKY / jade2php

Unlock Jade for PHP! Convert Jade templates into raw PHP templates. CLI tool and JavaScript API. Test covered.
43 stars 10 forks source link

Inline and delay require calls #39

Closed janwirth closed 8 years ago

janwirth commented 8 years ago

@ivankravchenko I had to inline these calls for the online demo I created today. Is this fine?

janwirth commented 8 years ago

Tests are running

janwirth commented 8 years ago

bump @ivankravchenko http://pug2php.netlify.com/

ivankravchenko commented 8 years ago

Hi @FranzSkuffka! It's probably fine, but why would you need to inline requires?

janwirth commented 8 years ago

Using browserify I had to make the require calls lazier as they invoke fs.readFileSync and the fs object is not available in the browser environment. The solution in this PR is not that good because we have some redundancy now. As you are familiar with the architecture, which approach do you suggest?

ivankravchenko commented 8 years ago

:+1: