SEACrowd / seacrowd-datahub

A collaborative project to collect datasets in SEA languages, SEA regions, or SEA cultures.
Apache License 2.0
65 stars 57 forks source link

Closes #66 | Create dataset loader for Filipino Gay Language (Swardspeak) #66 #293

Closed mrafifrbbn closed 8 months ago

mrafifrbbn commented 9 months ago

Closes #66. Note: there are 3 separate Excel files for this dataset. I was not sure whether each correspond to train/test/validation, so I combined everything as train.

Checkbox

Makefile output (author name contains special character):

Screenshot 2024-01-05 at 23 35 06

Test run output:

Screenshot 2024-01-05 at 23 34 21
ljvmiranda921 commented 8 months ago

Hi @mrafifrbbn , do you need any help making the changes?

mrafifrbbn commented 8 months ago

Hi @ljvmiranda921 , sorry I just noticed the email. Thank you for the review! I'll make the changes soon

mrafifrbbn commented 8 months ago

I made the fix, but I made a mistake and had to force push my local commit.. would this pose any problem?

ljvmiranda921 commented 8 months ago

It should be fine, later on we'll squash all the commits in this PR into a single commit. @mrafifrbbn

ljvmiranda921 commented 8 months ago

LGTM! Let's just wait for @yongzx 's review

yongzx commented 8 months ago

Tested, and the code looks good to me! Merging it now