Closes #276 | Implement PRDECT-ID dataloader

[ljvmiranda921]

Closes #276

Might need some help in the tests. I can make the source schema pass, but not the seacrowd ones. I think what's peculiar in this dataset is that it has two types of labels for the same TEXT schema. I can make the data loader work by running the following code:

from datasets import load_dataset
sentiment_dset = load_dataset("seacrowd/sea_datasets/prdect_id/prdect_id.py", name="prdect_id_sentiment_seacrowd_text")
emotion_dset =  load_dataset("seacrowd/sea_datasets/prdect_id/prdect_id.py", name="prdect_id_emotion_seacrowd_text")

Checkbox

• [x] Confirm that this PR is linked to the dataset issue.
• [x] Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
• [x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
• [x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
• [x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
• [x] Confirm dataloader script works with datasets.load_dataset function.
• [x] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
• [ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

[ryanignatius]

Might need some help in the tests. I can make the source schema pass, but not the seacrowd ones. I think what's peculiar in this dataset is that it has two types of labels for the same TEXT schema.

I search from our existing dataloaders and found similar case in id_google_play_review maybe we can use the same approach?

[holylovenia]

Might need some help in the tests. I can make the source schema pass, but not the seacrowd ones. I think what's peculiar in this dataset is that it has two types of labels for the same TEXT schema.

I search from our existing dataloaders and found similar case in id_google_play_review maybe we can use the same approach?

Hi @ljvmiranda921, I've tried and tested this dataloader. Everything works well. I will approve it after you modify the source schema as suggested by @ryanignatius.

[ljvmiranda921]

Got it! Will update within the week 👍

[ljvmiranda921]

@ryanignatius @holylovenia PR updated! Feel free to review again 🙇

[ryanignatius]

@ljvmiranda921 thank you for the update

sorry for not being clear before, in the id_google_play_review we have 2 sources for id_google_play_review_source and id_google_play_review_posneg_source

I'm suggesting to change current prdect_id_source to prdect_id_emotion_source and prdect_id_sentiment_source wdyt?

[ljvmiranda921]

Ah I see. So there will be a source and seacrowd config for both prdect_id_emotion and prdect_id_sentiment, no? Will update

[ljvmiranda921]

Hi reviewers @ryanignatius and @holylovenia , it's now ready for another round of reviews :)

To be honest, I'm not sure if I did it right. I have now two configurations for emotion and sentiment but the data loading logic is still the same. Kind of similar to id_google_play_reviews. Let me know if there's any needed changes!