Closed danjohnvelasco closed 7 months ago
Other than one minor fix below, I have nothing more to suggest. LGTM!
Fixed, thanks for the review! :)
Replacing @gentaiscool with @jen-santoso due to no response.
Hi @danjohnvelasco, thank you for the dataloader implementation.
So this case is a source-only, right? The dataloader runs well, just two nits here and the dataloader's good to go!
Hi @jen-santoso, thanks for the review. Yes, this is source-only. Your suggested changes are commited.
OK LGTM, merging now.
Closes #193
Checkbox
seacrowd/sea_datasets/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
.This dataset is a lexicon. It does not support any tasks. This case is similar to https://github.com/SEACrowd/seacrowd-datahub/pull/155
To run tests: