SEACrowd / seacrowd-datahub

A collaborative project to collect datasets in SEA languages, SEA regions, or SEA cultures.
Apache License 2.0
65 stars 57 forks source link

Closes #193 | Create dataset loader for MALINDO Morph #332

Closed danjohnvelasco closed 7 months ago

danjohnvelasco commented 8 months ago

Closes #193

Checkbox

Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.

This dataset is a lexicon. It does not support any tasks. This case is similar to https://github.com/SEACrowd/seacrowd-datahub/pull/155

To run tests:

python -m tests.test_seacrowd_source_only seacrowd/sea_datasets/malindo_morph/malindo_morph.py
danjohnvelasco commented 8 months ago

Other than one minor fix below, I have nothing more to suggest. LGTM!

Fixed, thanks for the review! :)

holylovenia commented 8 months ago

Replacing @gentaiscool with @jen-santoso due to no response.

danjohnvelasco commented 7 months ago

Hi @danjohnvelasco, thank you for the dataloader implementation.

So this case is a source-only, right? The dataloader runs well, just two nits here and the dataloader's good to go!

Hi @jen-santoso, thanks for the review. Yes, this is source-only. Your suggested changes are commited.

jensan-1 commented 7 months ago

OK LGTM, merging now.