Closes #365 | Implement dataloader for KDE4

ssun32 commented 8 months ago

Closes #365

Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script seacrowd/sea_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py.
[x] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

yongzx commented 7 months ago

Tested this with python -m tests.test_seacrowd seacrowd/sea_datasets/kde4/kde4.py and encountered the following error. @ssun32 did you download them locally when you create this, or is it that perhaps the url currently down?

File "/Users/yong/Dev/env_seacrowd/lib/python3.8/site-packages/datasets/utils/file_utils.py", line 596, in get_from_cache
    raise FileNotFoundError(f"Couldn't find file at {url}")
FileNotFoundError: Couldn't find file at https://opus.nlpl.eu/download.php?f=KDE4/v2/moses/af-ms.txt.zip

ssun32 commented 7 months ago

Tested this with python -m tests.test_seacrowd seacrowd/sea_datasets/kde4/kde4.py and encountered the following error. @ssun32 did you download them locally when you create this, or is it that perhaps the url currently down?
File "/Users/yong/Dev/env_seacrowd/lib/python3.8/site-packages/datasets/utils/file_utils.py", line 596, in get_from_cache
    raise FileNotFoundError(f"Couldn't find file at {url}")
FileNotFoundError: Couldn't find file at https://opus.nlpl.eu/download.php?f=KDE4/v2/moses/af-ms.txt.zip

Hi @yongzx, it seems that opus people did a major overhaul to their website. I have updated the script with the latest download link.

yongzx commented 6 months ago

Works for me now! Approving this.

SEACrowd / seacrowd-datahub

Closes #365 | Implement dataloader for KDE4 #404

Checkbox