Closed Gyyz closed 6 months ago
Scripts Passed.
subset = uitvicov19qa1/2/3/4
_ans:
python -m tests.test_seacrowd seacrowd/sea_datasets/uit_vicov19qa/uit_vicov19qa.py --subset uit_vicov19qa_4_ans
make check_file=seacrowd/sea_datasets/uit_vicov19qa/uit_vicov19qa.py
Checked, LGTM.
One question: Is there any reasons why we have 4 subsets? Maybe we can just unite them into one, they are similar to me. What do you think @raileymontalan @Gyyz ?
I am OK with merging to just one
Checked, LGTM.
One question: Is there any reasons why we have 4 subsets? Maybe we can just unite them into one, they are similar to me. What do you think @raileymontalan @Gyyz ?
Agree. @Gyyz please implement only one subset here.
Checked, LGTM. One question: Is there any reasons why we have 4 subsets? Maybe we can just unite them into one, they are similar to me. What do you think @raileymontalan @Gyyz ?
Agree. @Gyyz please implement only one subset here.
@MJonibek @raileymontalan, hello, updated, please check.
Scripts Passed:
1.python -m tests.test_seacrowd seacrowd/sea_datasets/uit_vicov19qa/uit_vicov19qa.py
2.make check_file=seacrowd/sea_datasets/uit_vicov19qa/uit_vicov19qa.py
Checked, LGTM! One small nit: can you rerun
make check_file=seacrowd/sea_datasets/uit_vicov19qa/uit_vicov19qa.py
command, I see some changes after running it:
@MJonibek Yes, after make
script, the dictionary structure of the sample
will be changed, and all keys and values will be placed on the same line, which affects the code's readability a bit. So I will adjust the code again on the example dict
after make
script
Closes #275
Checkbox
seacrowd/sea_datasets/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
.