SEACrowd / seacrowd-datahub

A collaborative project to collect datasets in SEA languages, SEA regions, or SEA cultures.
Apache License 2.0
65 stars 57 forks source link

Closes #222 | Create dataset loader for CreoleRC #469

Closed zwenyu closed 7 months ago

zwenyu commented 7 months ago

closes #222

Checkbox

sabilmakbar commented 7 months ago

Hi @zwenyu, to make the reviewing tidier, would you like to separate config changes into a different PR? (so you can be attributed for bonus points in introducing new tasks, too)

zwenyu commented 7 months ago

@sabilmakbar I've removed the config changes in constant.py to a separate PR #502.

zwenyu commented 7 months ago

@sabilmakbar Thanks for the comments. I've pushed changes addressing the issues. I didn't see error for normalized, using datasets version 2.17.1, but I've added normalized now. Can you check if they are ok?

sabilmakbar commented 7 months ago

@sabilmakbar Thanks for the comments. I've pushed changes addressing the issues. I didn't see error for normalized, using datasets version 2.17.1, but I've added normalized now. Can you check if they are ok?

Initially, I pointed to the missing field of normalized in the SEACrowd Schema of KB under the relations column, which is okay if being filled with an empty list. But since your new changes also fill them with appropriate values, it works (and even better)!