Closed zwenyu closed 7 months ago
Hi @zwenyu, to make the reviewing tidier, would you like to separate config changes into a different PR? (so you can be attributed for bonus points in introducing new tasks, too)
@sabilmakbar I've removed the config changes in constant.py to a separate PR #502.
@sabilmakbar Thanks for the comments. I've pushed changes addressing the issues. I didn't see error for normalized, using datasets version 2.17.1, but I've added normalized now. Can you check if they are ok?
@sabilmakbar Thanks for the comments. I've pushed changes addressing the issues. I didn't see error for normalized, using datasets version 2.17.1, but I've added normalized now. Can you check if they are ok?
Initially, I pointed to the missing field of normalized
in the SEACrowd Schema of KB under the relations
column, which is okay if being filled with an empty list. But since your new changes also fill them with appropriate values, it works (and even better)!
closes #222
Checkbox
seacrowd/sea_datasets/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
.