Closes #578 | Add Dataloader ViCon

muhammadravi251001 commented 3 months ago

Title: Add Dataloader ViCon

First line PR Message: Closes https://github.com/SEACrowd/seacrowd-datahub/issues/578

Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py (please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its __init__.py within {my_dataset} folder.
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _LOCAL, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py or python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}.
[ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

yongzx commented 2 months ago

python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_noun
python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_adj
python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_verb

Thanks @muhammadravi251001! All the tests passed on my end.

muhammadravi251001 commented 2 months ago

python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_noun
python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_adj
python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_verb

Thanks @muhammadravi251001! All the tests passed on my end.

Alright, thanks for the info, Sir!

muhammadravi251001 commented 2 months ago

Just a small suggestion and I think we're good 👍

I've already commit the suggestion, Sir. Thanks!

ljvmiranda921 commented 2 months ago

Just waiting for @yongzx 's approval and we can merge :)

holylovenia commented 1 month ago

python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_noun
python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_adj
python -m tests.test_seacrowd seacrowd/sea_datasets/vicon/vicon.py --subset_id vicon_verb

Thanks @muhammadravi251001! All the tests passed on my end.

Hey @yongzx, I'm assuming you meant to approve this PR, thus I'm merging it.

SEACrowd / seacrowd-datahub

Closes #578 | Add Dataloader ViCon #607

Checkbox