Closed muhammadravi251001 closed 1 month ago
@muhammadravi251001 Checked, LGTM! Thank you for your work. Just small problem: can you delete unnecessary comment
Thanks for the review, Sir!
The citation has not been added yet to the code. Otherwise, this looks good!
Yup, the citation is still not provided because I still waiting for the workshop's notification.
But I guess you can approve it without the CITATION
for now (if it looks good on another aspect besides CITATION
), following my approved dataset PR like this one https://github.com/SEACrowd/seacrowd-datahub/pull/633.
Thanks for the review, Lucky!
Hi @luckysusanto, is there anything else that @muhammadravi251001 needs to address besides the pending _CITATION
? I'd like to merge the dataloader if you don't find any other issues.
Sorry for the slow response @holylovenia No, I don't have more to add. I was thinking of waiting until the citation is put before accepting. If it is not an issue, I'll approve now >.<. Thanks!
Title: Add Dataloader TyDIQA-ID-NLI
First line PR Message: Closes https://github.com/SEACrowd/seacrowd-datahub/issues/616
Notes
_CITATION
field, I will add it later.Checkbox
seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py
(please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its__init__.py
within{my_dataset}
folder._DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_LOCAL
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
orpython -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}
.