SEACrowd / seacrowd-datahub

A collaborative project to collect datasets in SEA languages, SEA regions, or SEA cultures.
Apache License 2.0
55 stars 54 forks source link

Closes #616 | Add Dataloader TyDIQA-ID-NLI #632

Closed muhammadravi251001 closed 1 month ago

muhammadravi251001 commented 3 months ago

Title: Add Dataloader TyDIQA-ID-NLI

First line PR Message: Closes https://github.com/SEACrowd/seacrowd-datahub/issues/616

Notes

Checkbox

muhammadravi251001 commented 2 months ago

@muhammadravi251001 Checked, LGTM! Thank you for your work. Just small problem: can you delete unnecessary comment

Thanks for the review, Sir!

muhammadravi251001 commented 2 months ago

The citation has not been added yet to the code. Otherwise, this looks good!

Yup, the citation is still not provided because I still waiting for the workshop's notification.

But I guess you can approve it without the CITATION for now (if it looks good on another aspect besides CITATION), following my approved dataset PR like this one https://github.com/SEACrowd/seacrowd-datahub/pull/633.

Thanks for the review, Lucky!

holylovenia commented 2 months ago

Hi @luckysusanto, is there anything else that @muhammadravi251001 needs to address besides the pending _CITATION? I'd like to merge the dataloader if you don't find any other issues.

luckysusanto commented 1 month ago

Sorry for the slow response @holylovenia No, I don't have more to add. I was thinking of waiting until the citation is put before accepting. If it is not an issue, I'll approve now >.<. Thanks!