SEACrowd / seacrowd-datahub

A collaborative project to collect datasets in SEA languages, SEA regions, or SEA cultures.
Apache License 2.0
64 stars 57 forks source link

Closes #223 | Add/Update Dataloader VinText #649

Closed patrickamadeus closed 4 months ago

patrickamadeus commented 5 months ago

Closes #223

Checkbox

Tests

image
patrickamadeus commented 4 months ago

Hi @akhdanfadh! I've addressed the suggestions! For now I will change the description and proceed with the original version of dataset.

Thank you for the meaningful reviews!

sabilmakbar commented 4 months ago

Hi, @akhdanfadh @fhudi. Would you like to review the latest code changes? Thanks!

holylovenia commented 4 months ago

Hi @fhudi @akhdanfadh, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then.

cc: @patrickamadeus

fhudi commented 4 months ago

Hi @akhdanfadh, It seems all the previous concerns have been addressed. Could you please re-review the latest code changes? thanks. cc: @sabilmakbar

akhdanfadh commented 4 months ago

@fhudi The code tested and OK. My only comment is that the change in image_text.py schema is insignificant. Could we remove that?

fhudi commented 4 months ago

@akhdanfadh sure, please do. I am fine with either one.

akhdanfadh commented 4 months ago

Merging now. @patrickamadeus @fhudi