Closed patrickamadeus closed 4 months ago
Hi @akhdanfadh! I've addressed the suggestions! For now I will change the description and proceed with the original version of dataset.
Thank you for the meaningful reviews!
Hi, @akhdanfadh @fhudi. Would you like to review the latest code changes? Thanks!
Hi @fhudi @akhdanfadh, I would like to let you know that we plan to finalize the calculation of the open contributions (e.g., dataloader implementations) in 31 hours, so it'd be great if we could wrap up the reviewing and merge this PR before then.
cc: @patrickamadeus
Hi @akhdanfadh, It seems all the previous concerns have been addressed. Could you please re-review the latest code changes? thanks. cc: @sabilmakbar
@fhudi The code tested and OK. My only comment is that the change in image_text.py
schema is insignificant. Could we remove that?
@akhdanfadh sure, please do. I am fine with either one.
Merging now. @patrickamadeus @fhudi
Closes #223
Checkbox
seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py
(please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its__init__.py
within{my_dataset}
folder._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_LOCAL
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_SEACROWD_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneSEACrowdConfig
for the source schema and one for a seacrowd schema.datasets.load_dataset
function.python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py
orpython -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}
.Tests