search

SEAPUNK / socketeer

yet another websocket framework
MIT License
3 stars 0 forks source link

Client: Should dummy ws prop be a better dummy prop or replaced w/ better handling in Client + ClientAbstract? #61

Open SEAPUNK opened 8 years ago

SEAPUNK commented 8 years ago

0.8.2 PR had in checklist:

"Remove dummy ws prop, replace with proper handling in ClientAbstract and Client"

Now I'm not so sure. Which way should I go? I don't feel right doing this:

this.ws = {
  readyState: WebSocket.CLOSED,
  CLOSED: WebSocket.CLOSED
}
SEAPUNK commented 8 years ago

No dummy props, it's hacky.

Use better handlers.