Open SEAPUNK opened 7 years ago
cc @alexhultman: How does this sound so far? I'm reworking my original PR to do just what's stated above instead, some of which is mostly the same.
Adding of the semistandard
linter and making the JS code conform to it will probably be a separate PR.
Once I get the "configure CIs" todo list done, I'll demonstrate to you what it looks like, and what the publish process will look like as well, so you can be the judge of whether it makes everyone's lives easier or not.
files
property to decide what goes in the published packagenpm publish
, prepares the npm package by downloading all the required native addons from the GitHub releases before publishing them, then reminding the publisher to edit the specific GitHub release, since it's currently a draft (relies on package.json version being the same as the git tag, unless we can figure out a better way to do this)Should the publish script not bother to download the binaries if they already exist in the
nodejs/
directory, allowing the publisher of not having to use the whole CI/GitHub release process, if they need/want to do it manually? This is potentially error prone.Unresolved issues:
npm test
, which will include linting tests and regular tests.