search

SECOORA / GUTILS

🌊 🚤 Python utilities for reading, merging, and post processing Teledyne Webb Slocum Glider data
MIT License
7 stars 11 forks source link

Pseudograms remix #16

Closed jr3cermak closed 2 years ago

jr3cermak commented 2 years ago

This PR addresses most issues in #12 and leaves one item open.

Adding entries to deployment.json enable and disabling of ecometrics/pseudogram processing:

    "extra_kwargs": {
        "enable_pseudograms": true,
        "echosounderRange": 60.0,
        "echosounderRangeBins": 20,
        "echosounderDirection": "up",
        "echosounderRangeUnits": "meters"
    },

The other keywords will need to be passed to the binary to ascii processor. We need a kwargs hook installed there to grab those options and pass to the pseudogram decoder.

pytests for the ecometrics3 set produce variables in the right dimension for the three known profiles. I had to kludge the extras profiles and add a single time element for it to output the sci_echodroid* and pseudogram_* variables. For now, profiles that do not have an overlapping pseudogram end up with a single time element will all missing data. When the profile is missing, the variable is not written.

This PR is incomplete. The ecometrics and ecometrics2 pytests still have signs of pseudogram_* variables. If they are not present, those variables should not be written out. I can finalize this portion hopefully Friday.