search

SECOORA / GUTILS

🌊 🚤 Python utilities for reading, merging, and post processing Teledyne Webb Slocum Glider data
MIT License
7 stars 11 forks source link

Unstable `axiom/gutils:latest` Docker image #31

Closed VeckoTheGecko closed 9 months ago

VeckoTheGecko commented 9 months ago

I saw in the push.yml workflow (which runs on push and PRs) that the image is built and uploaded to axiom/gutils:latest as part of testing. This might cause some confusion since latest in other projects usually refers to the latest stable version, rather than testing.

https://github.com/SECOORA/GUTILS/blob/2969e89898ff479ee30e263cdbb91d3124a12c6b/.github/workflows/push.yml#L116-L123

https://github.com/SECOORA/GUTILS/blob/2969e89898ff479ee30e263cdbb91d3124a12c6b/.github/workflows/push.yml#L156-L162

I'd recommend building locally for testing, or using the git SHA as tag.

The publish workflow (tagging with the version name in publish.yml) is correct though, so should be used instead for production.

Not a big issue, just an FYI for the community.

VeckoTheGecko commented 9 months ago

Actually, just realised I'm absolutely mistaken here (since push: false in the first instance, and push: true only when the branch is master). I was a bit trigger happy with the issue here