Add water_network instance

SECQUOIA / gdplib

An open library of Generalized Disjunctive Programming (GDP) models

BSD 3-Clause "New" or "Revised" License

9 stars 7 forks source link

Closed tristantc closed 2 weeks ago

tristantc commented 2 months ago

This pull request incorporates the water_network instance. Please review the changes and provide feedback. Thank you!

ZedongPeng commented 2 months ago

Hi @tristantc . The linter check failed.

I think the m.gam has already been fixed in the main branch. You need to merge the main branch and resolve the conflicts.
The other one is m.ue. I am not sure if it is a good name. If you want to use m.ue, you need to add ue to https://github.com/SECQUOIA/gdplib/blob/main/.github/workflows/typos.toml

tristantc commented 2 months ago

Thanks for the feedback, @ZedongPeng. I will stick with ue for now, but I am willing to switch it if there is a better way to name it.

tristantc commented 2 months ago

Good addition. Now, does it run with the benchmark code?

BigM and Hull MINLP reformulations work. Neither the logic-based methods nor enumeration yield the optimal solution.