search

SED-ML / KiSAO

Ontology of algorithms for analyzing biological models, their parameters, and their outputs
Artistic License 2.0
9 stars 0 forks source link

New term requests: maximum Adams order and maximum BDF order #19

Closed jonrkarr closed 3 years ago

jonrkarr commented 8 years ago

As discussed on the sed-ml mailing list:

https://sourceforge.net/p/sed-ml/mailman/message/34816341/

it turns out that there are situations where a single algorithm must use two different 'maximum order' terms; one for maximum adams order, and a second for maximum BDF order. I know you just added 'maximum order' (at my request--thank you!); can you now add maximum Adams order and maximum BDF order as children of 'maximum order'? Thank you!

Reported by: luciansmith

jonrkarr commented 8 years ago

Hi Lucian,

I have found out (sorry, that I have not looked better before when adding 'maximum order') that these parameters are already described as KISAO_0000220 ('LSODA maximum non-stiff order', synonym: 'Adams max order'), and KISAO_0000219 ('LSODA maximum stiff order', synonym: 'BDF max order'). However, they are LSODA-specific now. Would it be OK, if instead of creating new terms, I generalise the definition of these ones?

Original comment by: annazhukova

jonrkarr commented 8 years ago

Aha! I had looked for them myself, but also hadn't found them. Sure, that'd be perfect. And this is why I needed 'maximum order' in the first place, so feel free to back out 'maximum order' entirely, if that makes sense, and if we caught it in time.

Original comment by: luciansmith

jonrkarr commented 8 years ago

Original comment by: annazhukova

jonrkarr commented 8 years ago

Fixed in KiSAO version 2.3.10

Original comment by: annazhukova