Clarify math functions as to whether to ignore NaN

SED-ML / KiSAO

Ontology of algorithms for analyzing biological models, their parameters, and their outputs

Artistic License 2.0

9 stars 0 forks source link

Clarify math functions as to whether to ignore NaN #94

Closed luciansmith closed 3 years ago

luciansmith commented 3 years ago

The new dimension-reducing functions min/max/mean/etc. do not say whether to ignore NaN values. In theory, KiSAO could define a term for both versions (ignore/don't ignore), but at the least, the existing functions should clarify which version they are (and I vote for the 'ignore' version).

cf https://github.com/SED-ML/sed-ml/issues/56

jonrkarr commented 3 years ago

Agreed. For concreteness, the existing terms could be implemented using NumPy nanmean, etc.

luciansmith commented 3 years ago

Specified existing functions to ignore NaN, https://github.com/SED-ML/KiSAO/pull/95

jonrkarr commented 3 years ago

Closed by #95