search

SED-ML / sed-ml

Simulation Experiment Description Markup Language (SED-ML)
http://sed-ml.org
5 stars 2 forks source link

Incorrect kisao ids for seed and absolute tolerance in specification #173

Closed matthiaskoenig closed 3 years ago

matthiaskoenig commented 3 years ago

The kisao ids have been switched for seed and absolute tolerance in the specification and are incorrect at many places. KISAO:0000211 : absolute tolerance KISAO:0000488 : seed

E.g.

NOTE: the global ListOfAlgorithmParameters was added to SED-ML in Level 1 Version 4. As such, the only place to define a random seed (KISAO:0000211)

or in section 2.2.1.11 and listing 2.24

<listOfAlgorithmParameters>
2 <algorithmParameter name="seed" kisaoID="KISAO:0000211" value="23"/>
3 <algorithmParameter name="absolute tolerance" kisaoID="KISAO:0000488" value="1001"/>
4 </listOfAlgorithmParameters>

Solution: Check the kisao ids are correct and set name on all AlgorithmParameter examples in the spec.

luciansmith commented 3 years ago

Done!