search

SED-ML / sed-ml

Simulation Experiment Description Markup Language (SED-ML)
http://sed-ml.org
5 stars 2 forks source link

fixes applied dimensions (DO NOT MERGE YET) #175

Closed matthiaskoenig closed 3 years ago

matthiaskoenig commented 3 years ago

@luciansmith Can you check that you commited all your changes! I just started fixing minor things but have the feeling this is not the latest tex corresponding to the PDF. If everything is up to date this should be good to merge otherwise there should be some conflicts.

luciansmith commented 3 years ago

I have indeed committed all my changes. However, I don't agree with all of the changes you propose here. For one, you actually can have multiple AppliedDimension children; we discussed this in the meeting. If you have (say) the max of a 3D matrix, and list all three dimensions as child AppliedDimensions, you get the max single value for the matrix as a whole. The one disallowed situation is having no AppliedDimension children, as that would mean that you must leave the matrix as it was.

You also reversed my changes in the itemized list back to how it was when this was RemainingDimensions. Which is exactly what we don't want!

matthiaskoenig commented 3 years ago

Yes, something went wrong and somehow had old RemainingDimensions in my files (so somehow some things got reverted on my site). I will just close this and start from scratch :/