sourceRef should be named sourceReference on DataRange

[matthiaskoenig]

All attributes referencing other objects in SED_ML are named <object>Reference, i.e. modelReference or taskReference. For consistency the sourceRef attribute on the new DataRange should be renamed to sourceReference.

[luciansmith]

You make a good argument, but it's pretty late in the day to make a change like this. Is everyone else OK with the change? @nickerso @jonrkarr @fbergmann Tomas? I could make the libsedml change if so.

[jonrkarr]

Agreed, the name should be consistent with that of other attributes.

[fbergmann]

I'm fine with the change

[luciansmith]

Done!

[matthiaskoenig]

Thanks. This is great.

On Thu, Jul 29, 2021 at 8:16 PM Lucian Smith @.***> wrote:

Done!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SED-ML/sed-ml/issues/187#issuecomment-889357854, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG33OVRFOH53AFC64TFEZTT2GLGLANCNFSM5A2ACNXQ .

-- Matthias König, PhD. Junior Group Leader LiSyM - Systems Medicine of the Liver Humboldt Universität zu Berlin, Institute of Biology, Institute for Theoretical Biology https://livermetabolism.com @.*** https://twitter.com/konigmatt https://github.com/matthiaskoenig Tel: +49 30 2093 98435

[luciansmith]

Argh; there's a similar problem with 'taskRef' in the ParameterEstimationReport and other places. I'll put a fix in; hopefully we can get it in the revision...

(There's also the 'ExperimentRef' class, but changing a class seems a bit much, and it's all new; I'll just change the taskRef bits, since there are other places where it's 'taskReference'.)

[matthiaskoenig]

I agree. This should be fixed. I am in favour for renaming the class for clarity from ExperimentRef to ExperimentReference.

On Wed, Aug 4, 2021 at 7:48 PM Lucian Smith @.***> wrote:

Argh; there's a similar problem with 'taskRef' in the ParameterEstimationReport and other places. I'll put a fix in; hopefully we can get it in the revision...

(There's also the 'ExperimentRef' class, but changing a class seems a bit much, and it's all new; I'll just change the taskRef bits, since there are other places where it's 'taskReference'.)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SED-ML/sed-ml/issues/187#issuecomment-892851199, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG33OXCIZJQTV5J4DLIDKDT3F4OZANCNFSM5A2ACNXQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Matthias König, PhD. Junior Group Leader LiSyM - Systems Medicine of the Liver Humboldt Universität zu Berlin, Institute of Biology, Institute for Theoretical Biology https://livermetabolism.com @.*** https://twitter.com/konigmatt https://github.com/matthiaskoenig Tel: +49 30 2093 98435

[luciansmith]

I made an 'experimentReference' branch for this change; I feel like it's just enough of a larger change that we need some other input.

[fbergmann]

i'm fine with this change. We definitely should have a new PDF online though

[luciansmith]

I was holding off compiling the changes into the PDF because I felt like the PDF should still be the one we officially submitted to JIB, but that was probably an incorrect instinct. I'll upload the latest.

[fbergmann]

I just wanted the libSEDML release to mirror what is in the 'official' PDF that people can get to. Thank you. But you are right, we should keep the version submitted to JIB as another file.

[luciansmith]

This was indeed incorporated into the JIB submission.