search

SED-ML / sed-ml

Simulation Experiment Description Markup Language (SED-ML)
http://sed-ml.org
5 stars 2 forks source link

Sum and product are still missing from KISAO for the AppliedDimensions #192

Closed matthiaskoenig closed 3 years ago

matthiaskoenig commented 3 years ago

sum (ignoring NaN) and product (ignoring NaN) are still missing from KISAO to have full coverage of the L1V3 reducing math functions.

I will fix this as part of the updates in https://github.com/SED-ML/KiSAO/issues/93

Also we should add sentence to the min, max, sum and prod spec description which lists the KISAO term for the new functions.

luciansmith commented 3 years ago

Nothing needs to be changed in the SED-ML spec itself, right? I'm closing this, but if I'm wrong feel free to re-open.

matthiaskoenig commented 3 years ago

Is not important for the spec. Just opened this so we don't forget.

On Fri, Jul 30, 2021, 22:37 Lucian Smith @.***> wrote:

Closed #192 https://github.com/SED-ML/sed-ml/issues/192.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/SED-ML/sed-ml/issues/192#event-5093110780, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG33OV4H5OS5JZQIIWJ5F3T2L5PHANCNFSM5A4J7X3Q .