search

SED-ML / sed-ml

Simulation Experiment Description Markup Language (SED-ML)
http://sed-ml.org
5 stars 2 forks source link

Remove the Value class and replace with a doubleArray child of VectorRange. #49

Open matthiaskoenig opened 7 years ago

matthiaskoenig commented 7 years ago

Issue

Currently unclear what DataType is value in vector range. This came up in the discussion with Lucian is the question if value is a subclass of SED-Base, see https://docs.google.com/drawings/d/195Wmeo8WtE6daf80rLELxOP_jdclZbiRtadzq_vew5Q/edit

Proposal

luciansmith commented 7 years ago

In my opinion, the only reason to wrap a number in an XML element is so that you can annotate it and/or give in an ID or the like, and, as such, I think if it's going to exist at all, it should be a SEDBase. If we don't want that, we should just allow VectorRange to have a double array child, and remove (or make optional?) the element entirely.

-Lucian

On Thu, Sep 28, 2017 at 10:51 PM, Matthias König notifications@github.com wrote:

One thing which came up in the discussion with Lucian is the question if value is a subclass of SED-Base, see https://docs.google.com/drawings/d/195Wmeo8WtE6daf80rLELxOP_ jdclZbiRtadzq_vew5Q/edit

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SED-ML/sed-ml/issues/49, or mute the thread https://github.com/notifications/unsubscribe-auth/ABp91gB--hsDChnCTN7TVX_otfrPoiEUks5snIVdgaJpZM4PoObD .

fbergmann commented 7 years ago

I would rather not change that element for l1v3, i'm happy with any changes afterwards.

matthiaskoenig commented 7 years ago

Moved to L1V4, no UML arrow to SED-Base in L1V3, i.e. no base class of SED-Base. Decision in L1V4 with additional clarification.

Personally I would only to annotate the vector-range, not individual values within it. So something like a double array child would be good.

luciansmith commented 3 years ago

The Value now inherits from SedBase in the UML, but is not implemented as such in libsedml.

I'm actually happy with the current situation, because nobody cares, and if need be we can update libsedml in the future.

In the meantime, I'm bumping this to L2, proposing that we just change the values to a direct doubleArray child of VectorRange. Assuming we still have VectorRange in L2.

matthiaskoenig commented 3 years ago

agree