search

SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
110 stars 55 forks source link

Mapping Review Screen - field name case and punctuation #1172

Closed RDmitchell closed 6 years ago

RDmitchell commented 7 years ago

SHA: 341f613 instance: seeddemostaging browser: chrome, incognito files: covered-buildings-sample.csv & portfolio-manager-sample.csv (standard sample files) org; LBNL 300 (created new for this test)

Folder with sample file, including VIDEO showing this behavior (video for #1103 but shows these problems also) https://drive.google.com/open?id=0B3fTKpZ9Dx7LUGdROTJZVlRyN0U

PROBLEM # 1:

PROBLEM # 2:

nllong commented 7 years ago

this should really be resolved in #1191. I'll try and see if we can hack something in.

RDmitchell commented 6 years ago

Server Instance: dev1 Server SHA: 49fb8dd Org: Issue 1301

PR #1623 doesn't seem to have fixed this issue. And possibly made it worse, because the Inventory list view doesn't show the upper case mapping (even though it is wrong in the mapping review screen), which it used to do.

I still see the same issue in the Mapping Review screen that the field names, in terms of upper and lower case, are not shown as they were mapped or as they are going to show in the final Inventory list.

Here is the mapping image Here is what it looks like in the Mapping review screen -- the fields that are supposed to be all upper case are upper / lower image

List settings does not show the correct upper case mapping image

And the Inventory view does not have the correct upper case mapping either, which the previous versions did actually have correctly displayed. image

RDmitchell commented 6 years ago

instance: dev1 SHA: 8132824 Org: LBNL 300 (previously imported this same data file)

Importing the same file as above (from issue #1103), into an account that already had the previous mapping with upper and lower case when it should have had all upper case, the program doesn't save the new mapped fields with all upper case.

So this doesn't seem to be fixed

Mapping image

Mapping Review image

List Settings Some of the upper case fields are represented twice, but they are all camel-case not upper case as mapped image

Inventory Both fields with the same name have identical data, and none of the fields have the upper case components that were mapped image

RDmitchell commented 6 years ago

I had the same result when I made a completely new organization and imported the data, mapped with the capitalization, so no previous history of mapping.

@nllong / @axelstudios -- should I move this from Test to To Do?

I don't think we need to include this in the upcoming release -- it can wait until the next release.

nllong commented 6 years ago

Yes move this back. @axelstudios... did we ever end up saving the display names from the mapping review screen? On Thu, May 24, 2018 at 16:22 RDmitchell notifications@github.com wrote:

I had the same result when I made a completely new organization and imported the data, mapped with the capitalization, so no previous history of mapping.

@nllong https://github.com/nllong / @axelstudios https://github.com/axelstudios -- should I move this from Test to To Do?

I don't think we need to include this in the upcoming release -- it can wait until the next release.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/SEED-platform/seed/issues/1172#issuecomment-391884369, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0amg0sJyhzetW6alXM2sRKT9ypYifZks5t1zLBgaJpZM4LPxaF .

RDmitchell commented 6 years ago

When I imported the file above for testing, I imported it as a "spreadsheet", and the capitalization from the mapping wasn't kept.

However, when testing #1191, when a file was imported as an ESPM file, the capitalization for EUI was kept. Not sure what the difference is, but thought I would record that fact. image testing done on

nllong commented 6 years ago

and this?

RDmitchell commented 6 years ago

Instance: dev1 SHA: ?? got an error when I clicked on the "i" symbol Org: Issue 1301 (I guess Nick or Alex you renamed it from LBNL 300)

Seems to be working correctly now for file that is imported as a spreadsheet. The capitalization and punctuation is showing up at all levels -- mapping, mapping review, Inventory list and detail, list settings in list and detail.