SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
110 stars 55 forks source link

Portfolio Manager Automap: A few more updates (Parent Property ID & Energy Score) #1230

Closed RDmitchell closed 5 years ago

RDmitchell commented 7 years ago

instance: seedv2 SHA: 3daf0f8

A few more changes to the automapping that SEED does for Portfolio Manager files:

RDmitchell commented 7 years ago

Parent Property ID is getting mapped automatically to PM Parent Property ID

Energy Score is NOT getting mapped automatically to ENERGY STAR Score

image

nllong commented 7 years ago

yeah, this is because the field in the db is energy_score. We can either 1) add a new field called energy_start_score or 2) wait for display_names to be fleshed out because the mapping has the correct display name.

  {
    "display_name": "ENERGY STAR Score",
    "to_field": "energy_score",
    "to_table_name": "PropertyState",
    "from_field": "Energy Score",
    "units": "",
    "type": "float",
    "schema": ""
  }
RDmitchell commented 7 years ago

I guess I don't understand. Looking at the code snippet above, it seems like the display name is already set to "ENERGY STAR Score", which is all I'm asking. I guess I don't see that when I am running the code. Maybe I need to test again?

nllong commented 7 years ago

it won't show up until we serve the display names from the backend. which is on the list to do.

RDmitchell commented 7 years ago

I see.

The problem is that once users map their data they are pretty much stuck with that mapping forever. So if someone maps now to Energy Score, they won't really be able to ever set their data to map to ENERGY STAR Score in the future, unless we figure out some way to migrate the mapped names, which given my latest experience with data migration from V 1.5 to 2.0 is difficult and sometimes basically impossible. So it's too bad we can't figure out an interim solution that works for the current world and also for the future world.

And if they DO map to ENERGY STAR Score now, it ends up in the extra data field now, correct? So is that the right solution for what users should do now? And then later we look for that field in extra data and migrate it to the real energy_score field? It means that the Reports and the Data Cleansing won't work for that field because they are looking for the structured field called Energy Score, so I guess that's probably not a good solution

Sigh ...

nllong commented 7 years ago

we can make energy score always display ENERGY STAR Score in the near future.

if they map to ENERGY STAR Score now and not energy_score, it does end up in extra data.

I say they map to energy score for now... and try to fix their data later.

RDmitchell commented 7 years ago

ok, thanks

RDmitchell commented 6 years ago

instance: dev1 SHA: 844dde0 Org: LBNL 60

Created a new org to see what the latest default mapping is when importing via the new ESPM log in from SEED

Here are fields that need to change -- we should basically be using the same name in the SEED field name as in the ESPM file -- I tested on an ESPM file that didn't have all the possible fields, so this is probably an incomplete list.

image image image image image

Default Mapping that is already fixed, so don't need to worry about these:

nllong commented 6 years ago

@RDmitchell -- Let me know and I will address the remaining items. Thanks!

https://github.com/SEED-platform/seed/commit/6045923c04530a15f33ab9d89395bee3e979800f#diff-7e33ec1805a9b97d70d451655c07a66d

nllong commented 6 years ago

@RDmitchell -- let me know what you would like to do with these remaining items?

RDmitchell commented 6 years ago

@nllong -- looking at the https://github.com/SEED-platform/seed/blob/develop/seed/lib/mappings/data/pm-mapping.json file, there are three options for how the user could map a field and they would all end up mapping to the non-extra-data field energy_score. Have I interpreted that correctly? And if so, then your 2nd bullet isn't correct, ie, it would get mapped to energy_score and not to extra data? If that's true then that's good because we don't really want that field to be in extra_data. The other fields are fine as extra data.

image

RDmitchell commented 5 years ago

@nllong -- I think we can close this since we are not going to be using the ESPM default mapping scheme anymore. ??

nllong commented 5 years ago

I will happily close this one ;).