SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
110 stars 55 forks source link

500 Internal Server Error trying to rename columns in Column Settings if the column already exists #1903

Closed RDmitchell closed 5 years ago

RDmitchell commented 5 years ago

Expected Behavior

Be able to rename fields in the Column Settings screen (Maybe it is not possible to do what I am trying to do, but if not, the program should have a message for the user, rather than an internal server error).

Actual Behavior

In Column Settings, there are several fields with slightly different names, but all represent the same data. The attempt is to try to rename one field to the name of a field that already exists. image Clicking the rename button, I set the new name to be the same as the 2nd field, which has most of the words in lower case, as opposed to upper case. image Clicking the Confirm button, I get an Internal server error image

Steps to Reproduce

Import the same file twice, once as a Portfolio Manager file, accepting the default field names, which makes extra data fields have capitalized letters for the field names image Import the file again, as a Portfolio Manager file, this time clicking the "Map SEED fields to imported file fields" image (and then changing at least the first field, Property ID, to PM Property ID, so the program will accept the mapping. Now the SEED field has the same capitalization as the ESPM field. image And now in the Column Settings screen, there are two fields with slightly different names (due to Capitalization differences) which represent the same data image

Instance Information

instance: seeddemostaging SHA: 98a1fb00

RDmitchell commented 5 years ago

There is a sample file in the gdrive folder for this issue which can be used for testing Here is the link to the folder https://drive.google.com/open?id=14KS1Zsg_fdNVNA5m2a8KFfFdGTZl3rmv The filename is ESPM-FullFieldSet.xlsx

RDmitchell commented 5 years ago

instance: dev1 SHA: e120119 Org: LBNL 200 Cycle: 2019 Compliance

@axelstudios -- I didn't get an error when I tried to do this rename, but it didn't actually do what I thought it would do, which was to get rid of the name that I didn't want.

Here is what I was trying to do:

There are two fields with the same name but different capitalizations. I just want one field name, the one without all the words capitalized.

image

I basically want to rename the 2nd one to be the same as the first one, in the actual data, so that all the records have the same version of the field name.

I renamed the 2nd field to the first one and click the Confirm button image

The program says the column was renamed image

But the old name still shows up in the Column Settings list -- seems like it should no longer be there? image

nllong commented 5 years ago

Looks like this is an issue with casing. Should we allow user to rename columns that are simply a change of casing?

On Fri, Jul 19, 2019 at 7:43 PM RDmitchell notifications@github.com wrote:

instance: dev1 SHA: e120119 https://github.com/SEED-platform/seed/commit/e120119f4a6f0809c004973d7ad8ce4c95ea1110 Org: LBNL 200 Cycle: 2019 Compliance

@axelstudios https://github.com/axelstudios -- I didn't get an error when I tried to do this rename, but it didn't actually do what I thought it would do, which was to get rid of the name that I didn't want.

Here is what I was trying to do:

There are two fields with the same name but different capitalizations. I just want one field name, the one without all the words capitalized.

[image: image] https://user-images.githubusercontent.com/6314950/61572453-c1faf380-aa52-11e9-8bca-77871512fe78.png

I basically want to rename the 2nd one to be the same as the first one, in the actual data, so that all the records have the same version of the field name.

I renamed the 2nd field to the first one and click the Confirm button [image: image] https://user-images.githubusercontent.com/6314950/61572574-b01a5000-aa54-11e9-85fd-6f9c2059411a.png

The program says the column was renamed [image: image] https://user-images.githubusercontent.com/6314950/61572581-d04a0f00-aa54-11e9-95b7-d284f0f933c9.png

But the old name still shows up in the Column Settings list -- seems like it should no longer be there? [image: image] https://user-images.githubusercontent.com/6314950/61572589-f8397280-aa54-11e9-8286-6c210e94ae9d.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SEED-platform/seed/issues/1903?email_source=notifications&email_token=AAORVGWQYIZIGPME2BPNJW3QAJUSVA5CNFSM4HZE46OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ND4EA#issuecomment-513424912, or mute the thread https://github.com/notifications/unsubscribe-auth/AAORVGXHOGKTSXF3WHJVMOTQAJUSVANCNFSM4HZE46OA .

RDmitchell commented 5 years ago

users definitely need to be able to get rid of mappings like this -- it's very annoying to have to deal with both of them. It has caused lots of headaches for San Jose.

But it does bring up the issue of how the ESPM fields that are let to default in SEED end up being all upper case, rather than the case that the actual ESPM fields have. It might be worth fixing that also.

nllong commented 5 years ago

@RDmitchell - do we need to address the casing issue for this to be closed? or can we close and make a new ticket?

RDmitchell commented 5 years ago

@nllong -- The specific error that this issue was describing is not longer there.

So yes, I think this can be closed and a new issue made for my last comment. I can do that.

So I will close this issue.