search

SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
107 stars 55 forks source link

Add ability to delete extra data columns in Column Settings #1904

Closed RDmitchell closed 3 years ago

RDmitchell commented 5 years ago

This is a placeholder issue -- it may need more discussion and design once we decide to deal with it.

Expected Behavior

Add the ability to delete columns (rows) in the Column Settings screen. This would only be applied to "extra data" fields.

And if that field had data in it, when the field is deleted, any data associated with it would also be deleted (right?). So having a dialog box warning the user of that would be needed.

That functionality already exists in the API and it wouldn't be much work to add it to the UI

That would solve the problem show in the screenshot below, which can occur when different files are imported with slightly different mapping. This is particularly an issue that happens when ESPM files are imported using the default SEED ESPM mapping vs using the button in mapping that sets the mapping to the actual ESPM field name. image

Actual Behavior

n/a

Steps to Reproduce

n/a

Instance Information

instance: LBNL production SHA: df842634

axelstudios commented 4 years ago

As a related issue, the current API that allows users to delete columns needs to be improved because it currently allows users to delete non-extra-data columns. That can cause all sorts of issues around data quality checking, mapping, and matching

RDmitchell commented 4 years ago

@nllong / @axelstudios -- I just added this to the dec 2019 project and put it in Triage.

RDmitchell commented 4 years ago

instance: dev1 SHA: 38fb067 Org: LBNL 466

I don't see a delete button in Column Settings for extra data fields? image

adrian-lara commented 3 years ago

Apologies - we didn't update dev1 in time before you had a chance to review.

This is on dev1 and ready for you to test.

RDmitchell commented 3 years ago

instance: dev1 SHA: 1e0884dd3

Seems to be working