Unit Conversion - GHG Intensity

[dreneden1]

Is your feature request related to a problem? Please describe.

We are running an energy benchmarking program in British Columbia, Canada, and importing data from ESPM in SI units. In SEED, I can convert the Site and Source EUI from GJ/m2 to a few other options, but I don't have the same option for GHG intensity. This is super frustrating because I then need to download the excel and make the manual conversion before re-uploading to SEED, which effectively nullifies the use of the ESPM-SEED import.

Describe the solution you'd like

Ideally, I'd like to be able to convert the GHGI units in the same way that i can convert a few other fields in SEED, like GFA, Site/source EUIs.

Describe alternatives you've considered

It would be nice to have more visibility on units in general in SEED... In general, I'm a little confused on why you can do unit conversions for some fields and not others... is there a full list somewhere?

Additional context

Thank you!

[nllong]

Hi @dreneden1 -- This is a great question and aligns with some work that we are actively scoping. We are right now collecting data on what GHG gases we want to collect and in what units we want to collect them (e.g., CO2e in tons/kilograms/tons per sqmeter, NOx/SOx, etc). If you have any requirements, then please let us know!

[dreneden1]

Oh interesting, I wasn't even thinking about the GHG units, but more so the ability to convert GHGI from kgCO2/ft2 to kgCO2/m2. This is what would be really helpful.

Please let me know if that's possible and in the pipeline!

[nllong]

Gotcha. So we can assume that GHG is just kgCO2 for now -- so we would have kgCO2/ft2, tonCO2/ft2, kgCO2/m2, and kgCO2/ft2. Maybe some others?

[dreneden1]

I think you got it! kgCO2/ft2, kgCO2/m2, tonCO2/ft2, tonCO2/m2.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been closed automatically. If this still affects you please re-open this issue with a comment or contact us so we can look into resolving it.

[nllong]

Sorry, this ticket should not have been closed. We will get to this soon.

[nllong]

I think this has been completed. @Ryoken --can you confirm? If so, then move this ticket to "to deploy"

[Ryoken]

While units for GHG and GHG Intensity were already in place for new columns, existing columns did not get the data_type. After this PR is approved, you will be able to set a column's data type to "GHG" or "GHG Intensity", allowing you to select the units when mapping:

Set data type on settings:

See units on mapping:

GHG Units:

GHG Intensity Units:

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[RDmitchell]

Has this been pushed to the staging server for testing, or should it be tested on the dev1 server?

Also, should we move it to the FY 23 project and set to test, so that we can see all the issues that need testing in one place?

[nllong]

This is on dev1. Can you move the ticket to F23Q1?

[RDmitchell]

I just removed my giant comment with all the screenshots and my confusion to this doc https://docs.google.com/document/d/1rG8RvqvtvW8hzgSjd2T_XCDaMIqmh_Ta3g9RBBDk8mA/edit?usp=sharing

I think it's better to keep this issue a bit cleaner.

@dreneden1 -- I think that you should test this, possibly on our staging server, which is now updated to 2.17.0. I can make an account for you there if you want to do some testing there.

It does seem that what is described in the Sept 13 2022 comment is working but you should test it with you data and your understanding of what you are looking for.

[RDmitchell]

@nllong -- I am moving this to the Q2 project, setting the status to Test, with the idea that @dreneden1 will report back to us whether this implementation is what he is looking for.

[RDmitchell]

My one further comment about this, which is discussed in the above linked document, is that this fix only applies to GHG fields that are classified as "extra data". It appears that the canonical fields that are in the base database do not have the functionality to define the GHG units.

This seems like a major flaw in how this was implemented.

[dreneden1]

@RDmitchell sure we'd love to test it! If you make an account for me, I'll go and test it out.

Note that I don't have access to the gdoc that you posted. (my email is daniel@opentech.eco).

Finally, I'm not sure I understand your last comment - how does that impact things?

My one further comment about this, which is discussed in the above linked document, is that this fix only applies to GHG fields that are classified as "extra data". It appears that the canonical fields that are in the base database do not have the functionality to define the GHG units.

[nllong]

Finally, I'm not sure I understand your last comment - how does that impact things?

My one further comment about this, which is discussed in the above linked document, is that this fix only applies to GHG fields that are classified as "extra data". It appears that the canonical fields that are in the base database do not have the functionality to define the GHG units.

Thanks all! Regarding the above comment, the GHG fields do have units attached to them. I'm not sure yet on why they aren't showing up correctly in your org though Dan. If you go to your column settings in the org and filter on total_ what do you see? Do you see them like this where the datatype is number?

[dreneden1]

@nllong when I do the look-up that you recommended, I can see that the data type is "number", so that's good.

Actually, for one of our "organizations", I'm seeing the same thing that you posted above, but for another, the drop-down is available, but no data type is selected. (See screenshots below).

Either way, I'm understanding that the unit selection hasn't been implemented yet, right?

[RDmitchell]

Dan

I was supposed to make a test account for you on our staging server, but it looks like you have updated your code to reflect the new units that can be associated with GHG extra data fields.

Let me know if you would still like an account on our staging server, even for future testing.

Robin

On Tue, Jan 24, 2023 at 10:41 AM dreneden1 @.***> wrote:

@nllong https://github.com/nllong when I do the look-up that you recommended, I can see that the data type is "number", so that's good.

Actually, for one of our "organizations", I'm seeing the same thing that you posted above, but for another, the drop-down is available, but no data type is selected. (See screenshots below).

Either way, I'm understanding that the unit selection hasn't been implemented yet, right?

[image: image] https://user-images.githubusercontent.com/60278745/214379842-9a8e46ee-18a7-45c2-83ea-9042746c9738.png

[image: image] https://user-images.githubusercontent.com/60278745/214380074-74598425-0ff5-4460-90cb-ce5549672b88.png

— Reply to this email directly, view it on GitHub https://github.com/SEED-platform/seed/issues/2605#issuecomment-1402421748, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQFXRTWFO66JEDF3TVDALTWUAO7JANCNFSM4YKSV5ZQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Robin Mitchell Building Technology and Urban Systems Division Energy Technologies Area Lawrence Berkeley National Laboratory

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[dreneden1]

Hi @RDmitchell and @nllong - we have tested this on the NREL SEED Staging site and didn't get the expected results. Here is the test that we completed:

• In column settings, we set a column called GHG Intensity to the data type "GHG Intensity".
• We uploaded a file with GHG Intensity in kgCO2e/m2
• During mapping, we used the unit drop-down to select kgCO2e/m2 as the units.
• Finally, in the inventory, which shows the units in kgCO2e/ft2 by default, we can see that the units were not converted to kgCO2e/ft2 but remain in kgCO2e/m2. We would expect that setting the import units in metric would trigger a conversion on the inventory view which is in US IP.

Please let us know if you need more clarification on this!

[RDmitchell]

@dreneden1 -- thanks for testing. It seems like the conversion is not happening properly.

[isalanglois]

@dreneden1 Just wanted to let you know we are working on this and will provide an update by Friday

[Ryoken]

After working through this I was able to confirm that the units are not being converted as expected. We should implement the following:

1) Whenever the field is displayed, it should convert to the units specified in the organization settings. 2) The column header for a field (such as in the inventory list) should display matching units. 3) Add more display unit settings to the organization settings page.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[isalanglois]

@nllong Can you review this ticket?

[RDmitchell]

@isalanglois / @nllong / @kflemin -- it doesn't seem like any work has been done on this, so I think it should be moved to the 24 Bug Fix project under To Do.

[RDmitchell]

@isalanglois / @kflemin -- I removed this from the FY23 project since it is now in the FY24 bug fix project. Too confusing to be in both.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.