Mapping: Importing ESPM file doesn't ignore header lines

SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.

Other

110 stars 55 forks source link

Mapping: Importing ESPM file doesn't ignore header lines #2750

Closed RDmitchell closed 3 years ago

RDmitchell commented 3 years ago

Describe the bug The header lines in a standard ESPM input file are not being ignored.

Expected Behavior The standard 5 header lines in an ESPM file should be ignored.

Actual Behavior Imported a standard ESPM file as a "Spreadsheet", expecting the 5 header lines to be ignored, but they weren't and the mapping tried to include those as fields.

Steps to Reproduce

Import ESPM file with header lines (see link below for file) File: Derived Column Testing.xlsx Location: Issue folder G:\My Drive\SEED Shared Folder\Software Development\Issues\Issue 2750 https://drive.google.com/drive/folders/1QdBoSUJS9dnYlwqbLjyL8NfMwM5iEi-R?usp=sharing
Look at mapping, you will see the program has considered the header lines to be fields and the mapping is completely messed up

Instance Information

Instance: Dev1 SHA: 51bce4828

Additional Context

RDmitchell commented 3 years ago

see #2122 which is closed but is about the same problem.

RDmitchell commented 3 years ago

@macintoshpie / @nllong -- we need to fix this before putting this release on production.

macintoshpie commented 3 years ago

@RDmitchell I'll take a look at this tomorrow, but I will say that I've not had any issues importing other portfolio manager files.

RDmitchell commented 3 years ago

@macintoshpie -- right ... I am surprised that this came up.

macintoshpie commented 3 years ago

@RDmitchell it looked like all of the "empty" cells at the top of the spreadsheet actually each had an individual space (ie " "). I added a fixed file here, and it's now imported properly.

From recent tests on data from ESPM it seems like we shouldn't be too worried about this edge case, but is something to be aware of.

If you could test with the new file and verify it's working for you then I'm ok with closing this issue.

Screen Shot 2021-08-17 at 12 44 44 PM

RDmitchell commented 3 years ago

@macintoshpie -- interesting. I guess I can't trace the origins of this file, but I have tested importing ESPM files from other users with the 5 header lines at the top and don't have an issue, and this fixed file also imports, so I will close this.