search

SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
107 stars 55 forks source link

Bug: check meters tab on spreadsheet is broken #2810

Closed macintoshpie closed 2 years ago

macintoshpie commented 3 years ago

context

We added a function to check if there's a meters tab after a file is imported to prompt a user to import the meters as well.

bug

It doesn't work. E.g. I upload a BSync file and it asks if I want to import meters

RDmitchell commented 3 years ago

Instance: dev1 SHA: f3e9a4a Org: LBNL 405

I have seen inconsistent results for this for ESPM XLSX files with meter tabs; probably to do with how the spreadsheet it set up.

Sometimes SEED figures out there is meter data and asks if you want to import it, but sometimes it doesn't.

I think I will move this to the 12/31/2021 project, and assign it to me, so that I can try to figure out when it works and when it doesn't.

macintoshpie commented 3 years ago

@RDmitchell thanks, sounds like we do have some tweaking to do. I agree that moving it to the new project board is best. I'll also tag myself on this to make sure it doesn't slip through the cracks.

macintoshpie commented 2 years ago

I noticed that sometimes it takes a while for the "Import Meters" button to appear on some files that have meter data. This is because we immediately display the "results" modal, then start an HTTP request to check if we should show the import meters button. I wonder if that might be why @RDmitchell was sometimes seeing it and sometimes not (maybe it was just taking a second too long?)

@RDmitchell could you test this some more on dev1?

RDmitchell commented 2 years ago

@macintoshpie -- I observed this today, ie, I waited a few seconds and then the "Import Meters" option appeared when importing an ESPM file that had meters in it.

I have recorded a video that shows this -- you can see the behavior at 3:47 minutes in. Issue 2913.wmv: https://drive.google.com/drive/folders/1N2e7I2hm487hqnA6kTOgcPMbCPmwue8b?usp=sharing

macintoshpie commented 2 years ago

I think I'm going to close this ticket if that's ok with you @RDmitchell , the original bug has been fixed. I created this ticket to track the bad UX for a button showing up late: #2978

RDmitchell commented 2 years ago

@macintoshpie -- sure that's fine !!