SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
110 stars 55 forks source link

Update Portfolio Manager Defaults column mapping profile #2813

Closed RDmitchell closed 2 years ago

RDmitchell commented 3 years ago

Describe the bug The current "Portfolio Manager Defaults" Column Mapping Profile does not do a good job of actually mapping Portfolio Manager fields. image

Expected Behavior I expected that selecting that mapping profile would map the ESPM fields in the file I was importing

Actual Behavior Only a few fields were actually mapped when I selected that mapping (using the JCC ESPM file from #2808) image

Steps to Reproduce

Here is a more reasonable mapping, but basically we need to go through the standard ESPM fields and map them to SEED fields. image

I am happy to help with this task.

Instance Information

Instance: dev1 SHA: 24b503d2d

Additional Context none

RDmitchell commented 2 years ago

@nllong -- This is a tricky request because there are so many ESPM fields that are possible. The defaults currently there are OK, not great, but probably passable for now.

Would it be possible to add these three also? image

perryr16 commented 2 years ago

I can take a look at this

perryr16 commented 2 years ago

Hey @RDmitchell, when trying to reproduce the bug on production (https://seedv2.lbl.gov/) "Property Name" and "City" populated with the "Property Manager Defaults" profile. Could you pass along the file you were testing with?

https://user-images.githubusercontent.com/58446472/167028828-c342a28f-af1a-4911-966c-917c65ea7808.mov

RDmitchell commented 2 years ago

instance: dev1 SHA: 400ca8895

I don't see this change implemented in this version on dev1 image

Here is a link to a file to test with 2 - example-data-ESPM-Alerts-UBID.xlsx

RDmitchell commented 2 years ago

Instance: dev1 SHA: 1.449f54dcf

Property ID is still not being mapped to PM Property ID, same with Property Name and City, to name a few.

image

RDmitchell commented 2 years ago

@nllong thinks that possibly ESPM had a different name for Property ID and that is what SEED is mapping to PM Property ID.

So we need to figure out how to fix that.

RDmitchell commented 2 years ago

See https://github.com/SEED-platform/seed/blob/develop/seed/lib/mappings/data/pm-mapping.json

perryr16 commented 2 years ago

I'm having trouble duplicating this locally (see below). Testing on production might be more telling

https://user-images.githubusercontent.com/58446472/183979022-a81223bd-2aac-4598-9e20-11d6f621f46c.mov

RDmitchell commented 2 years ago

@perryr16 -- interesting. Maybe it has to do with the mapping for my particular org. Let me test on a brand new org and see if it works then.

RDmitchell commented 2 years ago

Instance: seedv2 production SHA: 09736c1d6

OK, so it definitely works properly for a completely new org without any previous import/mapping history. image

So I am going to close this issue.