SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
106 stars 55 forks source link

BETTER -- property report shows no savings, but SEED has values in the BETTER Savings fields #2852

Closed RDmitchell closed 9 months ago

RDmitchell commented 2 years ago

Describe the bug When I do a BETTER analysis, sometimes the BETTER html report shows NA and NA% for savings (cost, energy, etc), but when I look a the fields that SEED displays for the BETTER analysis, they have non-zero values in them.

Expected Behavior I would expect if the BETTER html report says NA for savings, that SEED would report 0 (although it should probably be blank or n/a), as it does for most of the records.

Actual Behavior SEED reports BETTER savings values under some conditions (no idea what those conditions are)

Steps to Reproduce Org: LBNL 404 Run analysis on "2550 Ninth Street" and you should see the behavior image

Instance Information Instance: dev1 SHA: 52586a6be

RDmitchell commented 2 years ago

@macintoshpie -- It does seem to be a BETTER issue. I think that the meter data from ESPM has meter types that BETTER can't handle.

image

So that would explain why the report says NA (maybe) but not why SEED is getting some results from BETTER -- maybe it can process through the API the meters it can deal with?

RDmitchell commented 2 years ago

@macintoshpie -- yes that appears to be the issue, ie, BETTER couldn't handle the meter types Potable.

Without those meter readings the BETTER analysis, at least in BETTER, gets non-zero savings.

I will reimport the fixed file into SEED and see if that fixes SEED also. image

Still the outstanding issue of why BETTER generated results that SEED could read when those results were not in the HTML report.

RDmitchell commented 2 years ago

Reimporting that file into SEED didn't improve the results in SEED from BETTER image

RDmitchell commented 2 years ago

@macintoshpie -- seems like we need to somehow capture the original error when the "potable" meters were in the data file, and BETTER produces an error about it, when I run BETTER natively at better.lbl.gov.

macintoshpie commented 2 years ago

I think we may need to talk about this is in person to make sure I understand what's happening.

I will note that I have seen this same issue, NA% in HTML, but numeric values in JSON response (what seed shows in the inventory list). It also appears that sometimes the changepoint model will only show up if both electricity and natural gas are included, but that needs to be confirmed.

RDmitchell commented 2 years ago

@macintoshpie -- here is a link to the file that I imported. It is one property, originally from the JCC data, but anonymized.

https://docs.google.com/spreadsheets/d/1iBrkjl3msPLIwUmKE7iJ-24Fiab0Bcde/edit?usp=sharing&ouid=103887815394604824348&rtpof=true&sd=true

This link isn't valid anymore -- see the link to the folder in the next comment

RDmitchell commented 2 years ago

@macintoshpie -- There are now two files -- one with 2 meters, electric and gas. It used to have 3 other meters, one for diesel, and 2 "potable" meters, which BETTER error'd on when I imported it into BETTER directly, so I took those meters (and their associated meter readings) out.

The meter for diesel is in the Meters tab but there isn't any data for it in the Meter Entries tab.

Here is a link to the gdrive folder that has both files for Berkeley, the one with only gas and electric, and the original that has all of the meters in it, including the ones that BETTER doesn't like.

https://drive.google.com/drive/folders/1iAky3PrK-yQYOVvu9NGr8gglpfSXdNkF?usp=sharing

image image

RDmitchell commented 2 years ago

Apparently the code running BETTER natively is different than the code that runs via API, so that might explain the differences ..??

RDmitchell commented 2 years ago

Han Li, the BETTER developer, confirmed that the BETTER dev and production servers get the same results.

macintoshpie commented 2 years ago

Related to #2869

nllong commented 2 years ago

Our understanding is that this is an issue on the BETTER side that needs to be resolved. Going to put in the icebox.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

RDmitchell commented 1 year ago

I will retest on the latest dev release -- I suspect this is still an issue, and we need to talk to the BETTER team to figure out how SEED can be smarter about this is possible.

RDmitchell commented 1 year ago

Instance: dev1 SHA: f9558b8bb Org: LBNL 200 Cycle: BETTER Meter Import Testing Files (referenced in a comment above also): https://drive.google.com/drive/folders/1iAky3PrK-yQYOVvu9NGr8gglpfSXdNkF?usp=sharing

@nllong -- I guess this has been fixed somewhat in that now SEED is only importing Natural Gas and Electric-Grid meters. Not sure if this is the best solution. It's good if doing a BETTER analysis, but what is someone is not doing that, and wants to get all the meter data into SEED?

Seems like a better solution would be to restrict the BETTER analysis, if there is one, to just the Natural Gas and Electric-Grid meters ... ???

This might become something that CERL will need, ie, they might have different fuel types that they want to import into SEED, so we probably need to support that.

Here is what I found.

Starting with the file that has 5 meters image Import that file and then the meter data into SEED -- only the Natural gas and electric-grid meters are imported image image In the Property Detail / Meter view, only the electric-grid and natural gas meters have been imported image

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

RDmitchell commented 10 months ago

I moved this to test to see if this is still an issue.

RDmitchell commented 9 months ago

I am going to close this issue, as it is quite old, do more BETTER testing (lots of things have changed since this was written), and start new issues if needed.