Fix BETTER issues

[anchapin]

When doing a BETTER portfolio analysis, the the individual building download link (the 'Portable Analytics Report' column of the 'Building Analytics List' table) in the Portfolio Report doesn't work as expected. It is expected that button would download the report to the computer for the user to open it. However, the following page is loaded instead.

Additionally, when the property type doesn't match one of the options available for the BETTER analysis, the error message gets cut off during property type 'Multifamily Housing' after 'Mul' (refer to the image below).

[RDmitchell]

@isalanglois / @nllong -- I would say this has high priority to fix along with the BETTER API work.

[perryr16]

A couple of notes here.

• The first issue is an X-Frame-Options issue and is on the BETTER server, not the SEED server. When a user clicks "download" the BETTER response headers are set to: X-Frame-Options: DENY. I have reached out to the BETTER team to see if they are able to change that header option.
• The second issue is a database setting. The AnalysisMessage model field is set to user_message = models.CharField(max_length=255...) and if a message is greater than 255 characters extra characters are removed and an ellipse "..." is added to the end of the message. This can be changed but will require a database migration.

[isalanglois]

@perryr16 is this complete? please confirm, thanks

[perryr16]

When viewing a Portfolio Analysis Standalone HTML file there are links to download the individual building analyses. However, the download button does not display within the SEED <iframe>. See the below correspondance from Han Li at LBNL

Hey @Ross Perry, @Daniel McQuillen and I have discussed the issue. The problem with the download links in the standalone portfolio analytics HTML is that they direct to BETTER web app (non API), which requires login. But our understanding is that individual SEED users don't have access to the master BETTER account. So our suggestion is that we disable the download links from the standalone portfolio HTML. You can add the download links somewhere outside of the iframe window via the standalone building analytics API

We will need to refactor the BETTER portfolio analysis flow to request individual PortfolioBuildingAnalyses for each building in the portfolio and attach them to the displayed analysis. I'm not sure where we should display the portfolio analysis.

Reference Documents BETTER V2 Documentation Notebook created by BETTER with example api calls

Email me for a Jupyter Notebook I created for testing the SEED-BETTER flow.

[RDmitchell]

@perryr16 -- I don't think I understand what the BETTER team is saying.

Does this mean that they are not making the individual analysis results available by API? That's the most important thing we want to see in SEED.

Can we have a discussion with them about changing that? I am happy to talk to Daniel about this.