Unhandled EEEJ Errors

[axelstudios]

Expected Behavior Errors should be presented to the user, and the analysis state should be accurate.

Actual Behavior EEEJ errors within celery are unhandled and the frontend shows the analysis in a perpetual Creating state:

This also results in constant progress-fetching for any page showing the analysis details.

Steps to Reproduce

1. Upload records with UBIDs and no address information
2. Attempt to run an EEEJ analysis

Additional Context KeyError: 'seed.analysis_pipelines.eeej._finish_preparation'

Celery log:

[
  [{
    "587": 1
  }, {
    "587": {
      "tract": null,
      "latitude": 39.68125868987877,
      "longitude": -105.12216195501026,
      "geocoding_confidence": "Manually geocoded (N/A)",
      "location": null
    }
  }, {
    "587": ["Property missing one of Address Line 1, City & State, or Postal Code)."]
  }, 2], {}, {
    "callbacks": null,
    "errbacks": null,
    "chain": [{
      "task": "seed.analysis_pipelines.eeej._run_analysis",
      "args": [2],
      "kwargs": {},
      "options": {
        "task_id": "17039268-fe43-4f62-8864-e501fabc9d33",
        "reply_to": "d11d4570-ffd1-3c2e-8067-a77195d674b8"
      },
      "subtask_type": null,
      "immutable": false
    }],
    "chord": null
  }
]

[RDmitchell]

@kflemin -- do we have a test dataset for this, ie, some records with UBIDs, so that I can do some monkey testing?

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.

[RDmitchell]

@axelstudios -- I assume this is still relevant?

[RDmitchell]

@axelstudios -- when I import a file that just has Custom ID 1 and UBIDs the program automatically creates Lat / Long, and then the EEEJ analysis is able to complete.

I don't have the mapquest API entered -- is there a way I can tell the program NOT to do the Geocoding, ie, don't generate the Lat/Long?

[RDmitchell]

@axelstudios -- never mind. Uncheck the Enable Geocoding !!

[RDmitchell]

Instance: Dev1 SHA: d5d60eaac Org: LBNL 245 File: Covered_Buildings_UBID-ONLY-anonymized-25Records https://docs.google.com/spreadsheets/d/1xCGarkrluJGZyK__Q4kLb4frMHkdU4tw/edit?usp=sharing&ouid=103887815394604824348&rtpof=true&sd=true

[RDmitchell]

It doesn't seem like turning Geocoding off results in NOT generating Lat/Long, which is what I would expect it to.

I will make a new issue for it.

As a result, I'm not sure how to test this, because having the UBID seems to always generate the Lat/Long values which allow the EEEJ analysis to be created.

Maybe I will try importing a file that doesn't have address or UBID info and see what the error looks like when I try to do an EEEJ analysis

[RDmitchell]

instance: dev1 SHA: d5d60eaac Org: LBNL 245 Imported a file with incomplete address info

Then tried to do an EEEJ analysis, and got this error in the upper right corner

@axelstudios -- can you suggest another way to test that includes the UBID that doesn't generate Lat/Long?

[RDmitchell]

@kflemin -- I have added the label "Testing Question" to this issue

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity within 60 days. It will be closed if no further activity occurs. Thank you for your contributions.