search

SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
106 stars 55 forks source link

Handle empty cycles on portfolio summary #4554

Closed perryr16 closed 4 months ago

perryr16 commented 4 months ago

Any background context you want to provide?

What's this PR do?

Handles the case when the current cycle (or baseline cycle) has no data.

Note: Things break down if baseline and current cycles have no overlapping data. The property filter can only filter one cycle at a time, meaning the second filter request uses the property ids from the first. If there are no overlapping properties the second filter will return empty. Fixing this would be very difficult.

How should this be manually tested?

create a goal with an empty baseline cycle create a goal with an empty current cycle create a goal with empty current and baseline cycles

What are the relevant tickets?

Screenshots (if appropriate)

Current Cycle Empty Screenshot 2024-02-28 at 5 28 36 PM Baseline Cycle Empty Screenshot 2024-02-28 at 5 28 08 PM Both Cycles Empty Screenshot 2024-02-28 at 5 27 32 PM

RDmitchell commented 2 months ago

instance: dev2 SHA: f3d92cbff Org; BB Full Run

I set up a Portfolio Summary where botht eh Baseline and Current Cycles are empty and the program doesn't show any data, which seems appropriate, and doesn't give an error, which also seems appropriate.

image

So I am going to close this issue