SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
106 stars 55 forks source link

Clear invalid label tags #4591

Closed perryr16 closed 3 months ago

perryr16 commented 3 months ago

Any background context you want to provide?

The label filters (and, or, exclude) are based attached to the model via a <tags-input> and <auto-complete> elements. If a valid label is selected, its value is attached to the <tags-input>'s ng-model. If invalid text is entered, it is not attached to the ng-model and not available to reset in $scope. This makes clearing the text difficult.

What's this PR do?

After resetting the ng-model's labels, the trashcan icon will also re-render the <tags-input> element, clearing any remaining text.

It's a little hacky, but it's cleaner than trying to locate the correct HTML element within , clear its contents, and convince the element that it is now in a 'valid' state.

How should this be manually tested?

Add a few labels. Filter on those labels. Add some random text to the filter fields. Hit the trash icon.

What are the relevant tickets?

4305

Screenshots (if appropriate)

https://github.com/SEED-platform/seed/assets/58446472/5b71532b-5f35-4ce6-adc6-066d1fbcbaba