SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.

Other

106 stars 55 forks source link

Fix circular derived column error handling #4601

Closed perryr16 closed 2 months ago

perryr16 commented 3 months ago

Any background context you want to provide?

What's this PR do?

fixes a bug causing the app to fail silently when a new derived column referenced an existing derived column.

How should this be manually tested?

create a derived column, dc1
create a second derived column, dc2 = dc1. Initially this failed silently, however this should be a valid action.
edit dc1 to dc1 = dc2. This should cause a circular warning to the user.

What are the relevant tickets?

4429

Screenshots (if appropriate)

https://github.com/SEED-platform/seed/assets/58446472/58a9bc52-5c28-4483-95e9-4bbca99eea56

kflemin commented 2 months ago

@perryr16, we do not want to allow derived columns that are made up of other derived columns.

perryr16 commented 2 months ago

@kflemin that goes against the feature that was introduced in #3305. Is the feature no longer needed?

perryr16 commented 2 months ago

This should be reworked to prevent users from defining derived columns using other derived columns