SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
107 stars 55 forks source link

Improve data logger validation error messages #4603

Closed perryr16 closed 1 month ago

perryr16 commented 6 months ago

Any background context you want to provide?

The data logger create/update modal had some hard coded error messages and backend logic that didn't align.

What's this PR do?

Dynamically displays error messages to the user Refactors the create and update endpoints to use a serializer to validate data and generate errors.

Based on the existing data logger model, the only required fields are property, display_name, and is_occupied_data. I used this as the source of truth for refactoring the view logic.

How should this be manually tested?

Create/update a data logger, make sure error messages are applicable.

What are the relevant tickets?

4592

Screenshots (if appropriate)

kflemin commented 1 month ago

closing as these changes are already on develop!