search

SEED-platform / seed

Standard Energy Efficiency Data (SEED) Platform™ is a web-based application that helps organizations easily manage data on the energy performance of large groups of buildings.
Other
106 stars 55 forks source link

Fix ubid bugs #4613

Closed perryr16 closed 2 months ago

perryr16 commented 2 months ago

Any background context you want to provide?

This is in response to some bugs Robin encountered while testing the UBID work

What's this PR do?

How should this be manually tested?

The following test files include the NREL FTLB, the NREL Cafe, and an invalid property without a ubid. Each file increases the ubid footprint.

  1. set matching criteria to only ubid
  2. upload a file with ubids 3props_ubids_0.xlsx
  3. in org settings change the ubid threshold to 0.1 to allow matching
  4. upload a file with slightly different ubids 3props_ubids_1.xlsx
  5. properties should have been merged and preferred ubid set to the incoming ubid (see inventory detail ubid)
  6. change the org setting ubid threshold to something more strict, like 0.9
  7. upload a file with slightly different ubids 3props_ubids_4.xlsx
  8. new views have been created as incoming properties did not meet matching criteria
  9. change the org setting ubid_threshold back to 0.1
  10. upload a file with slightly different ubids 3props_ubids_5.xlsx
  11. all properties with overlapping ubids should have been merged and ubid history preserved
  12. unmerge a merged property, check ubid history for each property

What are the relevant tickets?

Screenshots (if appropriate)