search

SEEG-Oxford / movement

R package containing useful functions for the analysis of movement data in disease modelling and mapping
20 stars 16 forks source link

Movement issue96 cran warnings #101

Closed KathrinTessella closed 9 years ago

KathrinTessella commented 9 years ago

Addressed several of the reported CRAN warnings in issue https://github.com/SEEG-Oxford/movement/issues/96 -> need to check which warnings or notes are still generated after this first bunch of fixes

codecov-io commented 9 years ago

Current coverage is 71.99%

Merging #101 into master will not affect coverage as of 01c7a2d

@@            master    #101   diff @@
======================================
  Files            1       1       
  Stmts          707     707       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            509     509       
  Partial          0       0       
  Missed         198     198

Review entire Coverage Diff as of 01c7a2d

Powered by Codecov. Updated on successful CI builds.

KathrinTessella commented 9 years ago

Outstanding issues after the commit: 

* checking Rd cross-references ... WARNING
Unknown package ‘gDistance’ in Rd xrefs

Examples with CPU or elapsed time > 5s
       user system elapsed
kenya 8.224  0.063   8.289
goldingn commented 9 years ago

Ah, my mistake, that should be: \code{\link[raster]{adjacent}}

KathrinTessella commented 9 years ago

Outstanding warnings with the latest commit (due to new method): 

* checking S3 generic/method consistency ... WARNING
as.data.frame:
  function(x, row.names, optional, ...)
as.data.frame.movement_matrix:
  function(movement_matrix)
See section ‘Generic functions and methods’ in the ‘Writing R
Extensions’ manual.