search

SEEG-Oxford / movement

R package containing useful functions for the analysis of movement data in disease modelling and mapping
20 stars 16 forks source link

Movement issue46 implement transformation #75

Closed KathrinTessella closed 9 years ago

KathrinTessella commented 9 years ago

@goldingn : this is a first try to apply the transformations to the optim() function. So far it is not working as I am not sure if I apply the helper function 'transformFluxObjectParameters' (which does the transformation and returns a list of the transformed params - this is working backed up with tests) at the correct place. I will come back to it tomorrow as I am running out of time today. But I wanted to show you my first attempt for any comments/feedback etc.

goldingn commented 9 years ago

Looks like you've always used it correctly, but you just need an extra one inside fittingWrapper. I've left comments inline on those commits with more details.

codecov-io commented 9 years ago

Current coverage is 73.07%

Merging #75 into master will decrease coverage by -0.01% as of 8a23279

@@            master     #75   diff @@
======================================
  Files            1       1       
  Stmts          587     598    +11
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            429     437     +8
  Partial          0       0       
- Missed         158     161     +3

Review entire Coverage Diff as of 8a23279

Powered by Codecov. Updated on successful CI builds.

KathrinTessella commented 9 years ago

This addresses the issue https://github.com/SEEG-Oxford/movement/issues/46

goldingn commented 9 years ago

great!